Skip to content

Commit

Permalink
MRG: Merge pull request #533 from octue/devops/remove-git-mkver-file
Browse files Browse the repository at this point in the history
Remove `mkver.conf` file and update troubleshooting docs
  • Loading branch information
cortadocodes committed Oct 19, 2022
2 parents f0b1cab + 4b7ec8e commit 24b0ba0
Show file tree
Hide file tree
Showing 13 changed files with 3,471 additions and 218 deletions.
5 changes: 3 additions & 2 deletions .github/workflows/python-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,10 @@ jobs:
- uses: actions/checkout@v3
with:
fetch-depth: 0
- uses: octue/check-semantic-version@1.0.0.beta-1
- uses: octue/check-semantic-version@1.0.0.beta-3
with:
version_source_type: pyproject.toml
path: pyproject.toml
breaking_change_indicated_by: minor

run-tests:
if: "!contains(github.event.head_commit.message, 'skipci')"
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/update-pull-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,13 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: octue/generate-pull-request-description@1.0.0.beta-1
- uses: octue/generate-pull-request-description@1.0.0.beta-2
id: pr-description
with:
pull_request_url: ${{ github.event.pull_request.url }}
api_token: ${{ secrets.GITHUB_TOKEN }}
- name: Update pull request body
uses: riskledger/update-pr-description@v2
with:
body: ${{ env.PULL_REQUEST_DESCRIPTION }}
body: ${{ steps.pr-description.outputs.pull_request_description }}
token: ${{ secrets.GITHUB_TOKEN }}
55 changes: 30 additions & 25 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
exclude: 'build|.git/|.tox|dist|octue.egg-info'
exclude: "build|.git/|.tox|dist|octue.egg-info"
default_stages: [commit]
fail_fast: true
default_language_version:
python: python3 # force all unspecified python hooks to run python3
python: python3 # force all unspecified python hooks to run python3
repos:
- repo: https://github.com/pre-commit/pre-commit-hooks
rev: v4.3.0
Expand All @@ -21,55 +21,60 @@ repos:
rev: 22.6.0
hooks:
- id: black
args: ['--line-length', '120']
args: ["--line-length", "120"]

- repo: https://gitlab.com/pycqa/flake8
rev: 3.9.2
hooks:
- id: flake8
language_version: python3
additional_dependencies:
- 'pep8-naming'
- "pep8-naming"
args:
- --ignore-names=setUp,tearDown,setUpClass,tearDownClass,asyncSetUp,asyncTearDown,setUpTestData,failureException,longMessage,maxDiff,startTestRun,stopTestRun

- repo: https://github.com/pre-commit/mirrors-prettier
rev: v2.7.1
hooks:
- id: prettier

- repo: https://github.com/pycqa/pydocstyle
rev: 6.1.1
hooks:
- id: pydocstyle
- id: pydocstyle

- repo: https://github.com/thclark/pre-commit-sphinx
rev: 0.0.3
hooks:
- id: build-docs
language_version: python3
additional_dependencies:
- 'poetry==1.2.0b2'
- 'Sphinx>=4,<5'
- 'sphinx-rtd-theme>=1,<2'
- 'sphinx-tabs>=3,<4'
- 'sphinx-toolbox==3.0.0'
- 'git+https://github.com/octue/octue-sdk-python.git@main'
- "poetry==1.2.0b2"
- "Sphinx>=4,<5"
- "sphinx-rtd-theme>=1,<2"
- "sphinx-tabs>=3,<4"
- "sphinx-toolbox==3.0.0"
- "git+https://github.com/octue/octue-sdk-python.git@main"

- repo: https://github.com/windpioneers/pre-commit-hooks
rev: 0.0.5
hooks:
- id: check-branch-name
args:
- '^main$'
- '^development$'
- '^devops/([a-z][a-z0-9]*)(-[a-z0-9]+)*$'
- '^doc/([a-z][a-z0-9]*)(-[a-z0-9]+)*$'
- '^feature/([a-z][a-z0-9]*)(-[a-z0-9]+)*$'
- '^enhancement/([a-z][a-z0-9]*)(-[a-z0-9]+)*$'
- '^fix/([a-z][a-z0-9]*)(-[a-z0-9]+)*$'
- '^hotfix/([a-z][a-z0-9]*)(-[a-z0-9]+)*$'
- '^review/([a-z][a-z0-9]*)(-[a-z0-9]+)*$'
- '^refactor/([a-z][a-z0-9]*)(-[a-z0-9]+)*$'
- '^test/([a-z][a-z0-9]*)(-[a-z0-9]+)*$'
- '^style/([a-z][a-z0-9]*)(-[a-z0-9]+)*$'
- '^deprecation/([a-z][a-z0-9]*)(-[a-z0-9]+)*$'
- '^dependencies/([a-z][a-z0-9]*)(-[a-z0-9]+)*$'
- "^main$"
- "^development$"
- "^devops/([a-z][a-z0-9]*)(-[a-z0-9]+)*$"
- "^doc/([a-z][a-z0-9]*)(-[a-z0-9]+)*$"
- "^feature/([a-z][a-z0-9]*)(-[a-z0-9]+)*$"
- "^enhancement/([a-z][a-z0-9]*)(-[a-z0-9]+)*$"
- "^fix/([a-z][a-z0-9]*)(-[a-z0-9]+)*$"
- "^hotfix/([a-z][a-z0-9]*)(-[a-z0-9]+)*$"
- "^review/([a-z][a-z0-9]*)(-[a-z0-9]+)*$"
- "^refactor/([a-z][a-z0-9]*)(-[a-z0-9]+)*$"
- "^test/([a-z][a-z0-9]*)(-[a-z0-9]+)*$"
- "^style/([a-z][a-z0-9]*)(-[a-z0-9]+)*$"
- "^deprecation/([a-z][a-z0-9]*)(-[a-z0-9]+)*$"
- "^dependencies/([a-z][a-z0-9]*)(-[a-z0-9]+)*$"

- repo: https://github.com/octue/conventional-commits
rev: 0.8.1
Expand Down
14 changes: 7 additions & 7 deletions docs/source/asking_questions.rst
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ input values and/or an input manifest.
from octue.resources import Child
child = Child(
id="my-organisation/my-service",
id="my-organisation/my-service:latest",
backend={"name": "GCPPubSubBackend", "project_name": "my-project"},
)
Expand Down Expand Up @@ -122,15 +122,15 @@ if your app configuration file is:
"children": [
{
"key": "wind_speed",
"id": "template-child-services/wind-speed-service",
"id": "template-child-services/wind-speed-service:latest",
"backend": {
"name": "GCPPubSubBackend",
"project_name": "my-project"
}
},
{
"key": "elevation",
"id": "template-child-services/elevation-service",
"id": "template-child-services/elevation-service:latest",
"backend": {
"name": "GCPPubSubBackend",
"project_name": "my-project"
Expand Down Expand Up @@ -183,15 +183,15 @@ For example, if the child requires these children in its app configuration:
[
{
"key": "wind_speed",
"id": "template-child-services/wind-speed-service",
"id": "template-child-services/wind-speed-service:latest",
"backend": {
"name": "GCPPubSubBackend",
"project_name": "octue-amy"
},
},
{
"key": "elevation",
"id": "template-child-services/elevation-service",
"id": "template-child-services/elevation-service:latest",
"backend": {
"name": "GCPPubSubBackend",
"project_name": "octue-amy"
Expand All @@ -208,15 +208,15 @@ then you can override them like this:
children=[
{
"key": "wind_speed",
"id": "my/own-service",
"id": "my/own-service:latest",
"backend": {
"name": "GCPPubSubBackend",
"project_name": "octue-amy"
},
},
{
"key": "elevation",
"id": "organisation/another-service",
"id": "organisation/another-service:latest",
"backend": {
"name": "GCPPubSubBackend",
"project_name": "octue-amy"
Expand Down
2 changes: 1 addition & 1 deletion docs/source/creating_services.rst
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ octue.yaml
services:
- namespace: my-organisation
- name: my-app
name: my-app
It may also need the following key-value pairs:

Expand Down

0 comments on commit 24b0ba0

Please sign in to comment.