[tips] prioritized bubble opening #625
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a `priority` parameter to `Os_tips.bubble`, and changes the tips system to open bubbles on a given order.
balat
reviewed
May 3, 2021
balat
reviewed
May 3, 2021
| (* We wait for the elements to load, | ||
| to be sure we have all waiters prioritized *) | ||
| let%lwt () = onload_waiter () in | ||
| if not !sorted then |
There was a problem hiding this comment.
ocamlformat failed. We should probably add a commit hook?
There was a problem hiding this comment.
failed? Do we have a .ocamlformat in this repo?
balat
reviewed
May 3, 2021
src/os_tips.eliom
Outdated
| to be sure we have all waiters prioritized *) | ||
| let%lwt () = onload_waiter () in | ||
| if not !sorted then | ||
| (prioritized_waiters := List.rev !prioritized_waiters; sorted := true); |
There was a problem hiding this comment.
Why not sorting in reverse order directly?
There was a problem hiding this comment.
It would reverse the call-order too. On priority equality, first calls are inserted first, thus later in the list. We have no other reliable way to keep this order than reversing the list.
There was a problem hiding this comment.
That said, I'm currently sorting the list on every addition, which is suboptimal. I'll move the sort to this place so we only do it once (per batch)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
priorityparameter toOs_tips.bubble,and changes the tips system to open bubbles on a given order.
Behaviour on absent
priorityis unchanged.