Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove PredictSlot. #1045

Merged
merged 2 commits into from
May 15, 2024
Merged

Remove PredictSlot. #1045

merged 2 commits into from
May 15, 2024

Conversation

calina-c
Copy link
Contributor

Work on #1041.

@calina-c calina-c marked this pull request as ready for review May 15, 2024 10:45
@calina-c calina-c requested a review from idiom-bytes May 15, 2024 10:45
idiom-bytes
idiom-bytes approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@idiom-bytes idiom-bytes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed in code too, looks good.

@idiom-bytes idiom-bytes merged commit c283431 into issue685-duckdb-integration May 15, 2024
4 checks passed
@idiom-bytes idiom-bytes deleted the issue-1041-remove-predictslot branch May 15, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idiom-bytes idiom-bytes idiom-bytes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@calina-c @idiom-bytes