Csv datastore simplification #1043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added the last commit based on suggestions from Mustafa. @kdetry if it looks good to you without the instances part, there was also no point in keeping the high level data store, the new identifiers manage just fine. |
calina-c
force-pushed
the
csv-ds-simplification
branch
from
31e0504
to
4ea41ea
Compare
|
Hi, thanks for simplifying the process such that CSV signatures can be built from tables. But, why did the class have to be renamed? Not only that doesn't seem needed, but it's unfortunate... I've been trying to deprecate the name "dataset_identifier" for a long time... Now I'm seeing it used even more... We should just call it a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To follow-up on the booleans issue (ref #1015 and maybe #973)
Added rechunks and simplified data management for identifiers. Adds utility to create CSV identifiers from tables directly, but keep CSVDataStore for inspection purposes as well.