Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: dashboard failing build if NODE_ENV is changed #450

Merged
merged 1 commit into from
May 21, 2024

Conversation

jamiehewitt15
Copy link
Member

Fixes #448

Changes proposed in this PR:

  • Ensuring that NODE_ENV is always production for the dashboard build

@jamiehewitt15 jamiehewitt15 changed the title Ensuring that NODE_ENV is always production for the dashboard build Fix: dashboard failing build if NOD_ENV is changed May 15, 2024
@jamiehewitt15 jamiehewitt15 self-assigned this May 15, 2024
@jamiehewitt15 jamiehewitt15 changed the title Fix: dashboard failing build if NOD_ENV is changed Fix: dashboard failing build if NODE_ENV is changed May 15, 2024
@paulo-ocean
Copy link

actually this is also important for #397
#397

Copy link

@paulo-ocean paulo-ocean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@mariacarmina mariacarmina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jamiehewitt15 jamiehewitt15 merged commit 1b396b1 into develop May 21, 2024
6 checks passed
@jamiehewitt15 jamiehewitt15 deleted the issue-448-dashboard-build-fix branch May 21, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants