Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compute http routes #443

Merged
merged 1 commit into from
May 16, 2024
Merged

Fix compute http routes #443

merged 1 commit into from
May 16, 2024

Conversation

mariacarmina
Copy link
Member

@mariacarmina mariacarmina commented May 15, 2024

Fixes #442 .

Changes proposed in this PR:

  • add oceanNode to http routes for c2d
  • make oceanNode mandatory
message: '[HTTP] => [HTTP] => GET computeEnvironments request received with query: {}',
  timestamp: '2024-05-15 11:45:37'
}
{
  component: 'HTTP',
  moduleName: 'HTTP',
  level: 'error',
  message: "Error: TypeError: Cannot read properties of undefined (reading 'getRemoteCaller')",

Copy link

@paulo-ocean paulo-ocean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@jamiehewitt15 jamiehewitt15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@mariacarmina mariacarmina merged commit b28cc78 into develop May 16, 2024
6 checks passed
@mariacarmina mariacarmina deleted the fix-compute-http-routes branch May 16, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants