Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker image size reduction #432

Merged
merged 2 commits into from
May 20, 2024
Merged

Docker image size reduction #432

merged 2 commits into from
May 20, 2024

Conversation

jamiehewitt15
Copy link
Member

Fixes #410

Changes proposed in this PR:

  • Removing the dashboard development files from the docker image. Once the dashboard has been built into the static files, the development files (including a very large node modules folder) are not needed for anything.

Before the dashboard development files are deleted, we have:

$ du -c -s -h *
28K	API.md
1.6G	dashboard
44K	data
6.1M	dist
4.0K	Dockerfile
120K	docs
16K	env.md
12K	LICENSE
69M	logs
784M	node_modules
8.0K	package.json
668K	package-lock.json
12K	README.md
60K	schemas
8.0K	scripts
1.4M	src
4.0K	tsconfig.json
4.0K	tsoa.json
4.0K	typesense-compose.yml
236K	typesense-data
2.4G	total

After the dashboard development files are deleted we have:

$ du -c -s -h *
28K	API.md
44K	data
6.1M	dist
4.0K	Dockerfile
120K	docs
16K	env.md
12K	LICENSE
69M	logs
784M	node_modules
8.0K	package.json
668K	package-lock.json
12K	README.md
60K	schemas
8.0K	scripts
1.4M	src
4.0K	tsconfig.json
4.0K	tsoa.json
4.0K	typesense-compose.yml
236K	typesense-data
861M	total

Copy link

@paulo-ocean paulo-ocean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@mariacarmina mariacarmina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jamiehewitt15 jamiehewitt15 merged commit b8237fc into develop May 20, 2024
6 checks passed
@jamiehewitt15 jamiehewitt15 deleted the docker-image-size branch May 20, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants