Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deletion of DDO's by filter & add delete in batches #421

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

Fix deletion of DDO's by filter & add delete in batches #421

wants to merge 7 commits into from

Conversation

bogdanfazakas
Copy link
Member

@bogdanfazakas bogdanfazakas commented May 13, 2024 •
edited

Fixes #406 .

Changes proposed in this PR:

  • Fixed delete DDO by chainId function
  • Add batch size param for delete DDO by chainId

To test this:

  1. I've published 1000 assets using ocean-cli
Screenshot 2024-05-30 at 10 12 22
  1. Then triggered from the dashboard the reindex chain that is supposed to delete all assets and reindex all chain events
Screenshot 2024-05-30 at 10 09 32

@bogdanfazakas bogdanfazakas self-assigned this May 13, 2024
@bogdanfazakas bogdanfazakas changed the title Improve Batch delete Fix deletion of DDO's by filter & add delete in batches May 30, 2024
@bogdanfazakas bogdanfazakas marked this pull request as ready for review May 30, 2024 07:39
paulo-ocean
paulo-ocean approved these changes Jun 3, 2024
View reviewed changes
Copy link

@paulo-ocean paulo-ocean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulo-ocean paulo-ocean paulo-ocean approved these changes

@alexcos20 alexcos20 Awaiting requested review from alexcos20 alexcos20 is a code owner

@jamiehewitt15 jamiehewitt15 Awaiting requested review from jamiehewitt15 jamiehewitt15 is a code owner

@mariacarmina mariacarmina Awaiting requested review from mariacarmina mariacarmina is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

@bogdanfazakas bogdanfazakas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bogdanfazakas @paulo-ocean