Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emit events on reindex tx and chain #418

Merged
merged 11 commits into from
May 23, 2024
Merged

emit events on reindex tx and chain #418

merged 11 commits into from
May 23, 2024

Conversation

paulo-ocean
Copy link

@paulo-ocean paulo-ocean commented May 9, 2024 •
edited

Fixes #414

Changes proposed in this PR:

@paulo-ocean paulo-ocean self-assigned this May 10, 2024
@paulo-ocean paulo-ocean marked this pull request as ready for review May 10, 2024 09:42
mariacarmina
mariacarmina reviewed May 13, 2024
View reviewed changes
Copy link
Member

@mariacarmina mariacarmina left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions/open points from my side

src/test/integration/operationsDashboard.test.ts Outdated Show resolved Hide resolved
src/components/Indexer/crawlerThread.ts Show resolved Hide resolved
src/components/Indexer/crawlerThread.ts Outdated Show resolved Hide resolved
@paulo-ocean paulo-ocean mentioned this pull request May 14, 2024
Open
@paulo-ocean paulo-ocean mentioned this pull request May 21, 2024
Closed
jamiehewitt15
jamiehewitt15 approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@jamiehewitt15 jamiehewitt15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@paulo-ocean paulo-ocean merged commit 39632da into develop May 23, 2024
6 checks passed
@paulo-ocean paulo-ocean deleted the issue-414-reindex-event branch May 23, 2024 15:07
@paulo-ocean paulo-ocean mentioned this pull request May 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariacarmina mariacarmina mariacarmina left review comments

@bogdanfazakas bogdanfazakas bogdanfazakas approved these changes

@jamiehewitt15 jamiehewitt15 jamiehewitt15 approved these changes

@alexcos20 alexcos20 Awaiting requested review from alexcos20 alexcos20 is a code owner

Assignees

@paulo-ocean paulo-ocean

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@paulo-ocean @bogdanfazakas @jamiehewitt15 @mariacarmina