Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vesting wallet and splitter contracts #744

Merged
merged 16 commits into from
Oct 6, 2023

Conversation

trizin
Copy link
Contributor

@trizin trizin commented Apr 10, 2023

Fixes #743

Changes proposed in this PR:

  • Add vesting wallet and splitter contracts.
  • Update deploy script.

Main source is https://github.com/oceanprotocol/vw-cli , here we are just syncing the contracts.

@trizin trizin linked an issue Apr 10, 2023 that may be closed by this pull request
Copy link
Member

@trentmc trentmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. But I defer to Alex for a proper sign-off on this.

@alexcos20
Copy link
Member

I will fix the errors

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slither found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@trizin
Copy link
Contributor Author

trizin commented Apr 10, 2023

I've resolved import and version errors

@alexcos20 alexcos20 changed the base branch from main to v2.0 July 27, 2023 05:59
@openzeppelin-code
Copy link

openzeppelin-code bot commented Sep 16, 2023

Add vesting wallet and splitter contracts

Generated at commit: a4c3dfc779f2445fd6c645a0be7231fa660744b0

🚨 Vulnerabilities Summary

Process Issues Results
Contract Inspector note
low
critical
Total
23
10
1
34
Dependency Checker Total 0

For more details view the full report in OpenZeppelin Code

@alexcos20 alexcos20 added this to the v2.0.0 milestone Sep 26, 2023
@alexcos20
Copy link
Member

still WIP, depends on audit result

@alexcos20 alexcos20 added the Status: InProgress Work in progress, don't merge label Sep 29, 2023
Copy link
Member

@alexcos20 alexcos20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alexcos20 alexcos20 merged commit 3ba4ee4 into v2.0 Oct 6, 2023
9 checks passed
@alexcos20 alexcos20 deleted the issue743-add-vesting-wallet-and-splitter-contracts branch October 6, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: InProgress Work in progress, don't merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Vesting wallet and Splitter contracts
3 participants