Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added API support for IOC #100

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Conversation

tomsail
Copy link

@tomsail tomsail commented Aug 3, 2023

implemented the API requests through IOC, using the query flag. See Issue #47

Extraction is significantly faster.

The most significant change being:

  • the main channel (parameter "sensor": reference here and example here) is being automatically renamed 'slevel' and all other channels are ignored.

More testing might be needed

Copy link
Member

@pmav99 pmav99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the _api() functions don't seem to have any differences. If you intend to update them, then for sure keep them, but if they are going to be the same I would just reuse the existing ones.

Another thing that black will complain about is the single line between function definitions. Please use 2 empty lines instead of one.

searvey/ioc.py Outdated Show resolved Hide resolved
searvey/ioc.py Outdated Show resolved Hide resolved
searvey/ioc.py Outdated Show resolved Hide resolved
searvey/ioc.py Outdated Show resolved Hide resolved
searvey/utils.py Outdated Show resolved Hide resolved
@pmav99
Copy link
Member

pmav99 commented Aug 7, 2023

The tests are failing due to reduced test coverage. We can change the minimum required threshold in pyproject.toml, but we do need to add some tests for the new API, too.

@tomsail
Copy link
Author

tomsail commented Aug 9, 2023

I'll look into adding a test later this week. I'll reuse when I am doing now to extract and concatenate years of data.

@tomsail
Copy link
Author

tomsail commented Sep 5, 2023

The tests are failing due to reduced test coverage. We can change the minimum required threshold in pyproject.toml, but we do need to add some tests for the new API, too.

I have added the test for the API https://github.com/tomsail/searvey/blob/api/tests/ioc_api_test.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants