-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added API support for IOC #100
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the _api()
functions don't seem to have any differences. If you intend to update them, then for sure keep them, but if they are going to be the same I would just reuse the existing ones.
Another thing that black will complain about is the single line between function definitions. Please use 2 empty lines instead of one.
The tests are failing due to reduced test coverage. We can change the minimum required threshold in pyproject.toml, but we do need to add some tests for the new API, too. |
I'll look into adding a test later this week. I'll reuse when I am doing now to extract and concatenate years of data. |
I have added the test for the API https://github.com/tomsail/searvey/blob/api/tests/ioc_api_test.py |
implemented the API requests through IOC, using the query flag. See Issue #47
Extraction is significantly faster.
The most significant change being:
More testing might be needed