Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove calls to KmeanOrder from notebook #25

Open
3 tasks
wleoncio opened this issue Oct 21, 2020 · 0 comments
Open
3 tasks

Remove calls to KmeanOrder from notebook #25

wleoncio opened this issue Oct 21, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@wleoncio
Copy link
Member

The following Notebooks contain calls to the legacy function KmeanOrder():

As per a warning on that function, KmeanOrder() has been replaced by pseudoTimeOrdering(), so all calls to KmeanOrder() should be replaced ASAP.

Ideally, just changing the name of the function called should suffice; if bugs occur, fixes should be made to pseudoTimeOrdering().

This change would allow us to remove KmeanOrder, thus reducing the code footprint and check time of the package (something DIscBIO is in need).

@wleoncio wleoncio added the enhancement New feature or request label Oct 21, 2020
@wleoncio wleoncio added this to the DIscBIO 2.0.0 milestone Oct 21, 2020
wleoncio added a commit that referenced this issue Oct 21, 2020
@wleoncio wleoncio modified the milestones: Future major release, Future minor release Nov 13, 2020
@wleoncio wleoncio removed this from the Next release (1.2.0?) milestone Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants