New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cookbooks for JSON serialization and deserialization #2415
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gpopides! ✨ Indeed, JSON is so common it is very useful to have this!
Let me know when this is ready for my review. The |
Sure, i will ping you a bit later when i will be able to adjust it based on the comments. Thanks! |
Co-authored-by: sabine <6594573+sabine@users.noreply.github.com>
Co-authored-by: sabine <6594573+sabine@users.noreply.github.com>
Co-authored-by: sabine <6594573+sabine@users.noreply.github.com>
Co-authored-by: sabine <6594573+sabine@users.noreply.github.com>
Co-authored-by: sabine <6594573+sabine@users.noreply.github.com>
Co-authored-by: sabine <6594573+sabine@users.noreply.github.com>
I have applied all of the suggestions (thanks for that) so the comments are more understandable now. Let me know if we need to adjust anything else |
I have added 2 new cookbook files for json serialization and deserialization. I believe this task is pretty common and would help people trying to learn the language.
I'm not an ocaml expert so i first looked myself in the cookbooks to see if there is one.
I also haven't found a PR for this, so i thought about sharing what i had to use for my needs.
I also have followed the idea of the yaml cookbook.
Any feedback would be welcome