-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Resources Page to the Community Section #2184
Conversation
Hello, @cuihtlauac, @shakthimaan and @SaySayo , Please help me review this to see if I'm on the right track. Regards. |
Please help me review the second task I just pushed. @cuihtlauac, @shakthimaan and @SaySayo Regards. |
Hello @cuihtlauac @SaySayo , I got this error when I added the Please what does the error mean and how do i go about it? or is it because I have not updated the src/ocamlorg_data/lib/data.ml ? Regards. |
kindly help review this @cuihtlauac |
@0xrotense Sorry I missed your message yesterday. That's because you haven't added the type resource in |
okay, thanks will look into that. |
Hi @cuihtlauac , Please help look into this. Thanks |
You must edit the files Essentially, the type defined in the |
Co-authored-by: Erik Martin-Dorel <erik.martin-dorel+devops@ik.me>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @0xrotense, thanks for starting this work with this contribution! ❤️
I took a moment and finished the rest of the tasks, so we can merge this now! ✨
Fixes: #2041
Proposed Designs by @sabine: https://www.figma.com/file/7hmoWkQP9PgLTfZCqiZMWa/OCaml-Community-Pages?type=design&node-id=152%3A386&mode=dev&t=kePoh4Cvcc35Nemo-1
To Do:
data/resources.yml
, that will entail the new resources page. These are the fields needed for the YAML DATA: ddfb90f- Title
- Short description
- Long description
- Image
- Online Url
- Source Url
- License
tool/ood-gen/lib/resource.ml
. It translates into OCaml sources which are compiled and linked (ocaml.org runs from memory). 78ab3bdsrc/ocamlorg_frontend/pages/resources.eml
. There's the HTML template which is turned into the paged served with the Yaml data.-
src/ocamlorg_web/lib/handler.ml
-
src/ocamlorg_web/lib/router.ml
-
src/ocamlorg_data/lib/data.ml