Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid using lsof -Q which is only available from lsof 4.95.0 #581

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

erikmd
Copy link
Member

@erikmd erikmd commented Feb 9, 2024

(Debian 11 (oldstable) and Ubuntu 22.04 LTS both have lsof 4.93.2.)

The only drawback we could expect is generating a nonzero exit code, but the current implementation with Unix.open_process_in works as is.

  • Kind: bugfix

Description

Checklist

Note to maintainers

  • Read this wiki page.
  • Make sure the PR has a milestone.
  • Assign yourself before merging.
  • Either do a regular merge:
    • for PRs containing several commits following conventional-commits,
    • or for PRs containing 1 commit shared with a later PR (to preserve the SHA1)
  • Or do a squash-merge:
    • for PRs containing only 1 commit (not shared with a later PR),
    • or for PRs containing several commits that need not be kept in the history;
    • Update the commit message header with a conventional-commit type,
    • Add a footer Close #… if a related issue exists.

(Debian 11 (oldstable) and Ubuntu 22.04 LTS both have lsof 4.93.2.)

The only drawback we could expect is generating a nonzero exit code,
but the current implementation with Unix.open_process_in works as is.
@AltGr AltGr merged commit a242084 into ocaml-sf:master Feb 9, 2024
12 checks passed
@erikmd erikmd deleted the fix-gh-580 branch February 9, 2024 13:41
@erikmd erikmd added this to the learn-ocaml 1.0.0 milestone Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: learn-ocaml master can raise lsof: illegal option character: Q
2 participants