Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement pre-compilation of exercises and graders #481

Merged
merged 41 commits into from
Nov 3, 2023
Merged

Implement pre-compilation of exercises and graders #481

merged 41 commits into from
Nov 3, 2023
+2,091 −1,567

Commits on Nov 3, 2023

  1. feat!: Implement pre-compilation of exercises and graders 

    to cmi, cma and js.

Includes changes to the toploop to handle the dynamic loading.
    @AltGr
    AltGr committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    b03bdfe View commit details
    Browse the repository at this point in the history

  2. feat: Enable downloading for only the relevant artifacts (bc or js)

    @AltGr
    AltGr committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    47d5a06 View commit details
    Browse the repository at this point in the history

  3. refactor: Get rid of the pseudo-cipher 

    Finally :)

This should give a nice economy of bandwidth since the unciphered compilation
artifacts will compress much better.
    @AltGr
    AltGr committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    2792faf View commit details
    Browse the repository at this point in the history

  4. fix: Fix a small race condition in builder

    @AltGr
    AltGr committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    87ee902 View commit details
    Browse the repository at this point in the history

  5. perf: Make learn-ocaml build parallel by default 

    (now that it's fixed)
    @AltGr
    AltGr committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    eaad14c View commit details
    Browse the repository at this point in the history

  6. feat: Include Prelude/Prepare and shadow them 

    instead of just `open`. This restores the toplevel output on values defined in
Prelude, and forbids access to the interface of Prepare (which were two small
regressions with pre-compilation).
    @AltGr
    AltGr committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    787840b View commit details
    Browse the repository at this point in the history

  7. fix: Properly type samplers

    @AltGr
    AltGr committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    a97f813 View commit details
    Browse the repository at this point in the history

  8. fix: Avoid double-printing of internal grader errors

    @AltGr
    AltGr committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    7422ca4 View commit details
    Browse the repository at this point in the history

  9. perf: Dump the cmis for grading only once

    @AltGr
    AltGr committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    e63359e View commit details
    Browse the repository at this point in the history

  10. fix: Fix segfault on graders using samplers returning newly defined e… 

    …xceptions

(or extensible variant cases)
    @AltGr
    AltGr committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    c61a4d0 View commit details
    Browse the repository at this point in the history

  11. fix: Be more precise on the definition and lookup of samplers

    @AltGr
    AltGr committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    7825a6b View commit details
    Browse the repository at this point in the history

  12. build: Make make testrun parallel 

    (now that it works!)
    @AltGr
    AltGr committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    46631d8 View commit details
    Browse the repository at this point in the history

  13. feat(ppx-metaquot): Add transformation introducing the `register_samp… 

    …ler` calls

* A new transformation has been added that inserts
  `let () = Introspection.register_sampler name fun`
  for each toplevel binding prefixed with `sample_*` in test.ml.

* Compilation units stored in `demo-repository/exercises/exercise_name/`
  during the precompilation are no longer staged.
    @hernoufM @AltGr
    hernoufM authored and AltGr committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    3cd75f5 View commit details
    Browse the repository at this point in the history

  14. feat: Restore compatibility with static deployment 

    Previous patch on byte/js selection broke static servers. This restores
the compatible API by using GET args to filter the answer (on a static
server, no filtering will be done but that just means a little more
bandwidth usage).
    @AltGr
    AltGr committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    f0e8346 View commit details
    Browse the repository at this point in the history

  15. refactor: Rename and generalise recorder to ppx_autoregister 

    Functorising to add parameters so that it can be used to inject printer
registerers as well, for example.
    @AltGr
    AltGr committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    99e913d View commit details
    Browse the repository at this point in the history

  16. feat: Add support for a test_libs.txt file in exercises 

    It just contains the names of the ocamlfind libraries to link in.
    @AltGr
    AltGr committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    d22a788 View commit details
    Browse the repository at this point in the history

  17. feat: Preprocessing and typing of samplers and printers

    @AltGr
    AltGr committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    e768616 View commit details
    Browse the repository at this point in the history

  18. feat: Provide lib to compile grader helper libraries 

    and facility to link them during the `build` step.

NOTE: the helper library is going to be included in every exercise. A
lighter approach could be to keep loading it separately, e.g. after
loading the cma/js file from a directory holding static content on the
server (and removing the `.cma` from the compilation line in
`precompile_exercise.ml`).

This will probably fit well once we include such a mechanism for loading
custom libraries as the prelude to exercises, the main difference being
that the latter will also need the `cmi` files.
    @AltGr
    AltGr committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    3fc41ca View commit details
    Browse the repository at this point in the history

  19. fix: Fix printer registration in the grader

    @AltGr
    AltGr committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    7d27523 View commit details
    Browse the repository at this point in the history

  20. fix: Do some cleanup & Fix mutation_testing test lib 

    Now, an optional library that demonstrates the use of grader libraries.
    @AltGr
    AltGr committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    c432909 View commit details
    Browse the repository at this point in the history

  21. refactor: Generalize sampler typing 

    sync'ing with printer handling and the newer ppx that has the module name.
    @AltGr
    AltGr committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    264db4c View commit details
    Browse the repository at this point in the history

  22. fix: Allow printer registration in prepare/prelude & Fix print callba… 

    …cks' usage
    @AltGr
    AltGr committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    1ec3af6 View commit details
    Browse the repository at this point in the history

  23. refactor: Disable debug flags

    @AltGr
    AltGr committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    54851dd View commit details
    Browse the repository at this point in the history

  24. docs: Update French translation

    @AltGr
    AltGr committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    f028b75 View commit details
    Browse the repository at this point in the history

  25. docs!: Remove doc tutorial on depend.txt (it will need rewriting)

    @AltGr
    AltGr committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    9155145 View commit details
    Browse the repository at this point in the history

  26. docs: Update doc for pre-compiled exercises + test_libs.txt

    @AltGr
    AltGr committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    2c89d9e View commit details
    Browse the repository at this point in the history

  27. fix: Fix dune dependency glitch on recompilation of mutation_test

    @AltGr
    AltGr committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    32ad13e View commit details
    Browse the repository at this point in the history

  28. fix(docker): Include jsoo in Dockerfile, which is now needed

    @AltGr
    AltGr committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    466e80c View commit details
    Browse the repository at this point in the history

  29. fix(ci): Fix permission issues 

    `learn-ocaml build` now requires write access to the repository since it writes
compilation artefacts in-place.
    @AltGr
    AltGr committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    fa2cd23 View commit details
    Browse the repository at this point in the history

  30. docs: Add/Update copyright headers

    @AltGr
    AltGr committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    5b4e0ab View commit details
    Browse the repository at this point in the history

  31. fix: Expose prepare.ml file 

    Signed-off-by: Yann Regis-Gianas <yann@regis-gianas.org>
    @yurug @AltGr
    yurug authored and AltGr committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    365cbb7 View commit details
    Browse the repository at this point in the history

  32. fix(partition-view): Reactivate the feature 

    Signed-off-by: Yann Regis-Gianas <yann@regis-gianas.org>
    @yurug @AltGr
    yurug authored and AltGr committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    57ca10b View commit details
    Browse the repository at this point in the history

  33. fix(CLI): Report JSON parse error origin and locations

    @AltGr
    AltGr committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    ee57ac1 View commit details
    Browse the repository at this point in the history

  34. strengthening(grader): Add a safeguard against grading workers going … 

    …haywire

An uncaught exception could get caught upper on the stack, and lead the worker
to start running pending lwt stuff that belong to the master..

Also attempt to fix "too many open files" error with many workers
    @AltGr
    AltGr committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    cb417d1 View commit details
    Browse the repository at this point in the history

  35. fix(grader): allow exercises to use vg, gg 

    since the libraries are already available
    @AltGr
    AltGr committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    ead187e View commit details
    Browse the repository at this point in the history

  36. fix(teacher_tab): use newer asak compatible with precompilation 

    asak 0.4 is now released on opam
    @nobrakal @AltGr
    nobrakal authored and AltGr committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    942edc2 View commit details
    Browse the repository at this point in the history

  37. doc: update index.md

    @AltGr
    AltGr committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    f572990 View commit details
    Browse the repository at this point in the history

  38. fix(build): update lockfiles

    @AltGr
    AltGr committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    f1abb7d View commit details
    Browse the repository at this point in the history

  39. fix(CI): attempt to fix running the docker image on the corpus

    @AltGr
    AltGr committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    b94f053 View commit details
    Browse the repository at this point in the history

  40. fix(CI): disable compat tests with 0.12, 0.13 

    It's not expected that we remain compatible with versions that required exposing
`solution.ml`.
    @AltGr
    AltGr committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    91a418e View commit details
    Browse the repository at this point in the history

  41. fix(docker): install more libs in server image 

    these are required for compiling certain exercises
    @AltGr
    AltGr committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    6ce797f View commit details
    Browse the repository at this point in the history