Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(grader): Display negative numbers with mandatory parens #448

Merged
merged 3 commits into from Oct 15, 2021
Merged

fix(grader): Display negative numbers with mandatory parens #448

merged 3 commits into from Oct 15, 2021

Conversation

erikmd
Copy link
Member

@erikmd erikmd commented Oct 13, 2021

Fix #440

@erikmd erikmd self-assigned this Oct 13, 2021
@erikmd erikmd added this to the learn-ocaml 0.13.1 milestone Oct 13, 2021
@erikmd
Copy link
Member Author

erikmd commented Oct 15, 2021 •
edited

Actually the CI failure was due to the fact tests need to be updated. But the fix you suggested @letouzey works well indeed!

@erikmd
fix(grader): Display negative numbers with mandatory parens; Fix ocam…
35941b5 
…l-sf#440

* Thanks @letouzey for reporting this issue and suggesting a fix

* Update some learn-ocaml-client tests accordingly
@erikmd erikmd merged commit 2b7f304 into ocaml-sf:master Oct 15, 2021
@erikmd erikmd deleted the fix/440-neg-int branch October 15, 2021 13:43
@erikmd erikmd mentioned this pull request Nov 16, 2021
Closed
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@erikmd erikmd

Labels
kind: fix
Projects
None yet
Milestone
learn-ocaml 0.13.1
Development

Successfully merging this pull request may close these issues.

Bug: grader report may display negative numbers without mandatory parenthesis around them
1 participant
@erikmd