Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve description entrypoint #423

Merged
merged 2 commits into from Sep 29, 2021

Commits on Sep 29, 2021

  1. feat(description): Add learnocaml-exo-loading initial phase

    * in order to have as good an UX as that of exercises view
    erikmd committed Sep 29, 2021
    Copy the full SHA
    854ccf7 View commit details
    Browse the repository at this point in the history
  2. feat(description): Implement padding decoding

    * Aim: interoperate with learn-ocaml.el, which can encode the token by
    
      (base64-encode-string (format "%192s" "AAA-BBB-CCC-DDD") t)
    
      before opening the URL
    
      http://localhost:8080/description/:id#token1=:encoded
    
      with a 256-wide string for ":encoded" that couldn't be easily copied
      if, say, the user takes a screenshot of the exercise description.
    
    * For the moment, the support of legacy URLs
    
      http://localhost:8080/description/:id#token=AAA-BBB-CCC-DDD
    
      is still supported (but deprecated; it may be removed later on).
    erikmd committed Sep 29, 2021
    Copy the full SHA
    81b2ed8 View commit details
    Browse the repository at this point in the history