Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix learn-ocaml build -j 2 issue #416

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Fix learn-ocaml build -j 2 issue #416

wants to merge 4 commits into from

Commits on Sep 8, 2021

  1. test: Add -j 2 in corpus tests

    @erikmd
    erikmd committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    31b5750 View commit details
    Browse the repository at this point in the history

  2. fix(Lwt_utils.mkdir_p): Surround the Lwt_unix.mkdir call with a Lwt.c… 

    …atch guard

Aim: mitigate a TOC/TOU race condition which occurs when
Learnocaml_process_exercise_repository.n_processes > 1,
triggered by a command such as "learn-ocaml build -j 2".

This isn't the only possible fix/workaround, just a concise one
relying on error handling.
    @erikmd
    erikmd committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    8698753 View commit details
    Browse the repository at this point in the history

  3. Revert "fix(Lwt_utils.mkdir_p): Surround the Lwt_unix.mkdir call with… 

    … a Lwt.catch guard"

This reverts commit 8698753.
    @erikmd
    erikmd committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    e0e277d View commit details
    Browse the repository at this point in the history

  4. fix: some TOC/TOU race condition when running "learn-ocaml build -j 2" 

    Instead of tweaking Lwt_utils.mkdir_p, we add a call to this function
for the "www/static" directory before running the parallel build jobs.

MINOR-DRAWBACK: "www/static" is created even if there is no exercise!
    @erikmd
    erikmd committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    e191f59 View commit details
    Browse the repository at this point in the history