docs: Add CONTRIBUTING.md file
#452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikmd
force-pushed
the
add-contributing.md
branch
from
edd0e34
to
c1fc487
Compare
|
BTW I just noticed that when a
automatically generated with a link to that file + the issues tagged |
erikmd
force-pushed
the
add-contributing.md
branch
from
c1fc487
to
dc4a03a
Compare
|
FYI @yurug I also updated the wiki, https://github.com/ocaml-sf/learn-ocaml/wiki/Checklist-for-testing-and-merging-a-PR |
Closed
15 tasks
erikmd
added a commit
to pfitaxel/learn-ocaml
that referenced
this pull request
Dec 6, 2021
This patch, just required if PR <ocaml-sf#453> is merged before PR <ocaml-sf#452>, can be reverted anytime soon.
erikmd
added a commit
to pfitaxel/learn-ocaml
that referenced
this pull request
Dec 14, 2021
This patch, just required if PR <ocaml-sf#453> is merged before PR <ocaml-sf#452>, can be reverted anytime soon.
erikmd
force-pushed
the
add-contributing.md
branch
from
dc4a03a
to
1eeb0e0
Compare
erikmd
force-pushed
the
add-contributing.md
branch
2 times, most recently
from
f5ba0ba
to
ce9757c
Compare
Refactor & Extend the text from: https://github.com/ocaml-sf/learn-ocaml/wiki/Checklist-for-testing-and-merging-a-PR
erikmd
force-pushed
the
add-contributing.md
branch
from
ce9757c
to
ad479f4
Compare
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors and extends the text from:
https://github.com/ocaml-sf/learn-ocaml/wiki/Checklist-for-testing-and-merging-a-PR
which mostly results from standard conventions + those that are necessary because of the
release-pleasedependency.Proofreading is welcome!
(Cc @yurug @AltGr FYI)
Direct link to the rendered
.md[updated]