feat: Improve description entrypoint #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikmd
added
the
kind: enhancement
Closed
15 tasks
erikmd
force-pushed
the
improve-description
branch
from
cd930c2
to
a26af71
Compare
erikmd
added
the
needs: merge of dependency
* in order to have as good an UX as that of exercises view
* Aim: interoperate with learn-ocaml.el, which can encode the token by (base64-encode-string (format "%192s" "AAA-BBB-CCC-DDD") t) before opening the URL http://localhost:8080/description/:id#token1=:encoded with a 256-wide string for ":encoded" that couldn't be easily copied if, say, the user takes a screenshot of the exercise description. * For the moment, the support of legacy URLs http://localhost:8080/description/:id#token=AAA-BBB-CCC-DDD is still supported (but deprecated; it may be removed later on).
erikmd
force-pushed
the
improve-description
branch
from
a26af71
to
81b2ed8
Compare
erikmd
removed
the
needs: merge of dependency
erikmd
added a commit
to pfitaxel/learn-ocaml
that referenced
this pull request
Oct 3, 2021
* feat(description): Add learnocaml-exo-loading initial phase * in order to have as good an UX as that of exercises view * feat(description): Implement padding decoding * Aim: interoperate with learn-ocaml.el, which can encode the token by (base64-encode-string (format "%192s" "AAA-BBB-CCC-DDD") t) before opening the URL http://localhost:8080/description/:id#token1=:encoded with a 256-wide string for ":encoded" that couldn't be easily copied if, say, the user takes a screenshot of the exercise description. * For the moment, the support of legacy URLs http://localhost:8080/description/:id#token=AAA-BBB-CCC-DDD is still supported (but deprecated; it may be removed later on).
erikmd
added a commit
to pfitaxel/learn-ocaml.el
that referenced
this pull request
Oct 3, 2021
* (learn-ocaml-compute-questions-url): Add learn-ocaml-compute-questions-url-token1-compat to implement the elisp counterpart of PR <ocaml-sf/learn-ocaml#423>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This 2-commits PR builds upon #393; which should be merged before merging this one, #423 (with an optional rebase).
This PR implements the following item mentioned in #418:
/descriptionendpoint URL(following an idea discussed with @yurug some weeks ago)
It also incorporates a change (separate commit) to improve the
/descriptionUI/UX a bit regarding loading time,and error rendering: