Skip to content

Commit

Permalink
fix: Use HTML5 Doctype
Browse files Browse the repository at this point in the history
  • Loading branch information
erikmd committed Oct 3, 2021
1 parent 2c1347c commit fe0fe8b
Show file tree
Hide file tree
Showing 6 changed files with 6 additions and 5 deletions.
2 changes: 1 addition & 1 deletion static/description.html
@@ -1,4 +1,4 @@
<!doctype html>
<!DOCTYPE html>
<html>

<head>
Expand Down
2 changes: 1 addition & 1 deletion static/exercise.html
@@ -1,4 +1,4 @@
<!doctype html>
<!DOCTYPE html>
<html>
<head>
<meta charset="UTF-8">
Expand Down
1 change: 1 addition & 0 deletions static/index.html
@@ -1,3 +1,4 @@
<!DOCTYPE html>
<html>
<head>
<meta charset="UTF-8">
Expand Down
2 changes: 1 addition & 1 deletion static/partition-view.html
@@ -1,4 +1,4 @@
<!doctype html>
<!DOCTYPE html>
<html>
<head>
<meta charset="UTF-8">
Expand Down
2 changes: 1 addition & 1 deletion static/playground.html
@@ -1,4 +1,4 @@
<!doctype html>
<!DOCTYPE html>
<html>
<head>
<meta charset="UTF-8">
Expand Down
2 changes: 1 addition & 1 deletion static/student-view.html
@@ -1,4 +1,4 @@
<!doctype html>
<!DOCTYPE html>
<html>
<head>
<meta charset="UTF-8">
Expand Down

5 comments on commit fe0fe8b

@AltGr
Copy link
Collaborator

@AltGr AltGr commented on fe0fe8b Oct 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is weird... I noticed an issue where the loading animation doesn't display properly anymore (it's all the way to the right; and traced it back to this commit.

  • uppercase or lowercase doctype shouldn't matter according to the spec (lowercase seems more common since html5 is all lowercase)
  • index.html didn't actually have the doctype, so there must be a bug in the HTML structure that was hidden by the "quirks mode" without the doctype.

No time to debug this further atm unfortunately...

@AltGr
Copy link
Collaborator

@AltGr AltGr commented on fe0fe8b Oct 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(but maybe it could be better to revert the patch until we find a proper fix ?)

@yurug
Copy link
Collaborator

@yurug yurug commented on fe0fe8b Oct 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's indeed very weird. @erikmd any idea where this could come from?

@erikmd
Copy link
Member Author

@erikmd erikmd commented on fe0fe8b Oct 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AltGr for bisecting! indeed, the quirks-mode explanation you suggest looks very plausible; I'll have a look ASAP.

@erikmd
Copy link
Member Author

@erikmd erikmd commented on fe0fe8b Oct 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it! actually, the culprit is this line:

top: 0; left: 360; right: 0; bottom: 0;

Replacing 360 with 360px fixes the issue.

Will open/merge a PR.

Please sign in to comment.