New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ONNX runtime support #922

Merged

devrimcavusoglu merged 23 commits into obss:main from karl-joan:main

Jan 10, 2024

+1,082 −2

Contributor

karl-joan commented Jul 28, 2023 •

edited

Made changes to pull request #904 since the author didn't respond.

Changes:

Separated functions for image preprocessing and post-processing.
You can supply options to onnxruntime.
Fixed bugs in image post-processing, where iou_threshold was missing and bounding boxes were sent to non_max_supression in wrong format.
Fixed bug where sessions options weren't passed to onnxruntime.
Added some test.
Renamed onnx.py to onnx_model.py to avoid confusion with onnx library.

The code was designed with the intention of being used for YOLOv8 ONNX model. Perhaps some changes should be made to make it more suitable for other architectures.

karl-joan marked this pull request as ready for review

July 28, 2023 11:38

julled commented Aug 1, 2023

Thanks for continuing this work! I thinks its very important and i am looking forward to test this if you think its ready.

Contributor Author

karl-joan commented Aug 4, 2023

@julled You can go ahead and test it

LongLe18 commented Aug 4, 2023 •

edited

@karl-joan I tested your contribution. It's appear error like image below. And image which I used to test (https://ultralytics.com/images/bus.jpg)

Contributor Author

karl-joan commented Aug 6, 2023

@LongLe18 The test is meant to be run with image specified in the test file. If you change the image, then it won't work since the image you provided does not contain any cars.

If you just want to try the model, then use one of the built in functions such as get_sliced_prediction or get_prediction.

LongLe18 commented Aug 7, 2023

@karl-joan ok tks sir. I understood, you have not handled except yet. I will try again

Collaborator

fcakyon commented Nov 5, 2023

Thanks a lot for this amazing contribution @karl-joan !

If you could add a demo notebook as other model implementations, we would gladly merge the PR 👍

fcakyon requested changes

View reviewed changes

Collaborator

fcakyon left a comment

code styling errors need to be fixed, a demo notebook need to be added

fcakyon force-pushed the main branch 2 times, most recently from e78f5fe to f2b1019 Compare

November 6, 2023 08:58

fcakyon reviewed

View reviewed changes

requirements.txt Outdated Show resolved Hide resolved

fcakyon reviewed

View reviewed changes

sahi/auto_model.py Outdated Show resolved Hide resolved

fcakyon reviewed

View reviewed changes

sahi/models/__init__.py Outdated Show resolved Hide resolved

fcakyon reviewed

View reviewed changes

sahi/models/onnx_model.py Outdated Show resolved Hide resolved

fcakyon reviewed

View reviewed changes

tests/test_onnxmodel.py Outdated Show resolved Hide resolved

fcakyon reviewed

View reviewed changes

tests/test_onnxmodel.py Outdated Show resolved Hide resolved

fcakyon force-pushed the main branch from f2b1019 to ae67e75 Compare

November 6, 2023 11:08

Collaborator

fcakyon commented Nov 6, 2023

@karl-joan can you please fix the styling? https://github.com/obss/sahi#contributing

Contributor Author

karl-joan commented Nov 6, 2023

@fcakyon Yes, I'll try to get that and the notebook tomorrow done.

karl-joan force-pushed the main branch from d2197e8 to 13eb674 Compare

November 7, 2023 16:03

Contributor Author

karl-joan commented Nov 7, 2023

@fcakyon Let me know if you need anything else.

maikimati and others added 9 commits

November 25, 2023 22:48


          ONNX runtime compatibility

66aa3e0

ONNX models compatibility to speed up CPU inference in object detections


          ONNX model rework

48b5da4


          Update gitignore

96bf041


          Fix/clean code, add tests

e782db4


          Add documentation

b31ea0a


          Fix device if clause

37b6113


          Add docstring for init

59b5444


          Change import order

1b347f5


          Rename argument, move list index inside post

918a1ab

karl-joan and others added 14 commits

November 25, 2023 22:48


          Make ort sessions options optional

469f193


          Fix optional dict

2bbc586


          Fix bug where expected color chanel order was wrong

4aa5046


          Update requirements.txt

e86d4fc

Co-authored-by: fatih <34196005+fcakyon@users.noreply.github.com>


          Update sahi/auto_model.py

ae4e0dd

Co-authored-by: fatih <34196005+fcakyon@users.noreply.github.com>


          Update sahi/models/__init__.py

62152c3

Co-authored-by: fatih <34196005+fcakyon@users.noreply.github.com>


          Update sahi/models/onnx_model.py

0b2ed78

Co-authored-by: fatih <34196005+fcakyon@users.noreply.github.com>


          Update tests/test_onnxmodel.py

d14d9a5

Co-authored-by: fatih <34196005+fcakyon@users.noreply.github.com>


          Update tests/test_onnxmodel.py

190e941

Co-authored-by: fatih <34196005+fcakyon@users.noreply.github.com>


          Rename model files

45a6be7


          Add YOLOv8 ONNX demo notebook

4cfb605


          Update notebook

93ad68a


          Fix code formatting

131bc0b


          Fix tests

14c812b

fcakyon force-pushed the main branch from 13eb674 to 14c812b Compare

November 25, 2023 19:48

Member

devrimcavusoglu commented Jan 9, 2024

@karl-joan @fcakyon what is the status here ? I can take the lead, but I assume code formatting/linting has been addressed. As far as I reviewed the files, there are no additional requirements.

Contributor Author

karl-joan commented Jan 10, 2024

@devrimcavusoglu It's currently waiting behind @fcakyon

devrimcavusoglu self-requested a review

January 10, 2024 09:24

devrimcavusoglu approved these changes

View reviewed changes

Member

devrimcavusoglu left a comment •

edited

LGTM! Thank you for the contribution @karl-joan

devrimcavusoglu merged commit d91e1e6 into obss:main

9 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment