libobs: Ensure audio offsets are positive #10689
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Only set audio offset if current DTS is positive.
Motivation and Context
DTS/PTS can be negative for "priming" samples produced by AAC/Opus encoders, currently this would result in the DTS/PTS being corrected to 0, which causes A/V desync by making the silent priming samples part of the actual presentation.
By leaving the negative DTS/PTS the FFmpeg muxer (and #10608) can correctly set the encoder delay and ensure synced playback.
How Has This Been Tested?
Recorded a few videos of the Twitch sync test and validated that sync is now equivalent to PCM (there still seems to be one frame of delay somewhere in OBS).
(Note: #10690 was included here)
Types of changes
Checklist: