Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add additional log group to setup_ubuntu script #10679

Merged
merged 1 commit into from
May 16, 2024

Conversation

RytoEX
Copy link
Member

@RytoEX RytoEX commented May 15, 2024

Description

Add clear separation between the CEF setup and the apt/apt-get calls. This makes it easier to see how much time is being spent on each task.

Motivation and Context

Was comparing build times between the ubuntu-22.04 and ubuntu-24.04 runners, and it bothered me that the "CEF" step included the calls to apt-get.

How Has This Been Tested?

It hasn't, but it's a single line logging addition.

Types of changes

  • Tweak (non-breaking change to improve existing functionality)
  • Code cleanup (non-breaking change which makes code smaller or more readable)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

Add clear separation between the CEF setup and the apt/apt-get calls.
This makes it easier to see how much time is being spent on each task.
@RytoEX RytoEX added Code Cleanup Non-breaking change which makes code smaller or more readable CI labels May 15, 2024
@RytoEX RytoEX requested a review from PatTheMav May 15, 2024 18:59
@RytoEX RytoEX self-assigned this May 15, 2024
@RytoEX RytoEX merged commit c3c6c6c into obsproject:master May 16, 2024
14 checks passed
@RytoEX RytoEX deleted the add-setup-ubuntu-log-group branch May 16, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Code Cleanup Non-breaking change which makes code smaller or more readable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants