Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rnnoise: Fix compilation not working on latest gcc #10665

Merged
merged 1 commit into from
May 16, 2024

Conversation

cg2121
Copy link
Contributor

@cg2121 cg2121 commented May 12, 2024

Description

The latest gcc spits out an error (-Werror=calloc-transposed-args) about calloc parameters that are in the wrong order.

Motivation and Context

I'm on the latest version of Fedora which has the newest gcc and OBS doesn't compile.

How Has This Been Tested?

Compiled OBS

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

The latest gcc spits out an error about calloc parameters that are
in the wrong order.
@WizardCM WizardCM added the Bug Fix Non-breaking change which fixes an issue label May 12, 2024
@derrod
Copy link
Member

derrod commented May 12, 2024

Perhaps its time to get rid fo the vendored version as well, afaik we use system packages and obs-deps by default, this is just a fallback that existed because Ubuntu in the ancient times didn't have it.

Edit: It appears it still is ancient times

Copy link
Member

@RytoEX RytoEX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change seems to be correct. That said, this is vendored code that is sorely outdated. Once I get RNNoise updated in obs-deps, I plan to also update/replace this vendored code to the same version. However, to fix a compilation error, I'm willing to merge this for now.

@RytoEX RytoEX added this to the OBS Studio (Next Version) milestone May 16, 2024
@RytoEX RytoEX merged commit f60d6bc into obsproject:master May 16, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fix Non-breaking change which fixes an issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants