obs-webrtc: Add Link Header support #10524
Open
+94
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just tested this against OBS Studio and it seems to be working flawlessly. |
WizardCM
changed the title
sile
reviewed
Apr 16, 2024
Sean-Der
force-pushed
the
webrtc-turn
branch
2 times, most recently
from
654f876
to
4fe9a05
Compare
mogren
reviewed
May 3, 2024
|
@tt2468 Could I get a review of this one now please? |
Sean-Der
force-pushed
the
webrtc-turn
branch
2 times, most recently
from
6edce9e
to
b986f28
Compare
|
I have created a test application that confirms this is working. You can get it here https://github.com/Sean-Der/whip-turn-test The only thing you need to change is the IP address of the host you are running the server on here OBS without this patch running against this server behaves like this. It shows WHIP connected and starting pushing media. Without this change the server prints the following. OBS doesn't have TURN support so is unable to connect Some users today who are using WHIP will see OBS unable to connect and have no idea why |
DDRBoxman
requested changes
Jun 2, 2024
RytoEX
reviewed
Jun 3, 2024
Sean-Der
force-pushed
the
webrtc-turn
branch
2 times, most recently
from
92ca232
to
8192535
Compare
WHIP/WHEP allows ICE Servers to be specified via Link Headers[0] [0] https://www.ietf.org/archive/id/draft-ietf-wish-whip-13.html#name-stun-turn-server-configurat Co-authored-by: Takeru Ohta <phjgt308@gmail.com>
|
Thank you so much @DDRBoxman @RytoEX I really appreciate the reviews :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
WHIP/WHEP allows ICE Servers to be specified via Link Headers
Motivation and Context
Some WebRTC deployments are behind a NAT. Companies/developers place their TURN server on the edge, and use that to access the TURN servers.
I have had 3 companies reach out to me about this, so implemented it.
How Has This Been Tested?
Ran broadcast-box and only listened on
127.0.0.1and confirmed that traffic could be routed through pion/turnTypes of changes
Checklist: