Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for <Var> variables and environment variables within <Var> variable values #108

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ZimM-LostPolygon
Copy link
Contributor

No description provided.

@ZimM-LostPolygon
Copy link
Contributor Author

@lextm
Any specific reason why this and https://github.com/lextm/obfuscar/pull/107 are not getting merged?

@lextm
Copy link
Member

lextm commented Oct 22, 2017

Is it really a must? I evaluated its urgency but did not think it is urgent.

@ZimM-LostPolygon
Copy link
Contributor Author

Well, it's not a must, but it's something I needed when nesting configs.

@ZimM-LostPolygon
Copy link
Contributor Author

ZimM-LostPolygon commented Nov 6, 2017

lextm added the more info needed label 16 days ago

What kind of info do you need? This a small but useful change with no side-effects. It kind of makes sense to me that it should be possible to use vars and environment variables inside other vars. Otherwise they are not really vars, more like constants :)

I'm not trying to hurry you up or something like that, just asking if there is something particularly wrong with those PRs, and whether or not they will be merged in the future.

@ZimM-LostPolygon
Copy link
Contributor Author

ZimM-LostPolygon commented Jun 4, 2018

Is there something wrong with this PR? If you require some changes before merging, just let me know, I'd be glad to do them. It has been a year since this PR was made.

@krjw
Copy link

krjw commented Jul 29, 2019

Whats the status here? I could really use this feature!!!

@lextm lextm added tentative Not likely to be considered. Should use the workaround instead. and removed more info needed in progress labels Nov 20, 2022
@lextm
Copy link
Member

lextm commented Nov 20, 2022

After a long while, I'd like to mark this pull request as tentative.

If you really need to make the configuration dynamic, you might try to generate the XML file on-the-fly. In that way you always know what are the exact settings passed to Obfuscar during troubleshooting (while environment variables can be overridden freely and no recorded anywhere).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tentative Not likely to be considered. Should use the workaround instead.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants