New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support boolean schemas #605
Conversation
Hi @emonadeo! Thank you for the contribution and sorry for the late reply, I currently don't have much capacity for this project. Could you help me wrap my head around why and where this is useful in the context of Open API Spec? |
I personally don't use boolean json schema but others do and some codegen tools use it as well. Right now oazapfts just errors when trying to generate a client from such an openapi file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solid work! I have some minor change requests 🤓
🎉 This PR is included in version oazapfts-v6.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
oazapfts codegen fails if the api contains boolean json schema.
This PR adds support for these, mapping
true
toany
andfalse
tonever
.I am not sure about how this should behave with "TrueEnums" (
not sure what that isi get it now, these are typescript enums), so please review with extra care, as I am not familiar with the codebase and don't understand every corner of it.This is an upstream issue with
kogosoftwarellc/open-api
, which is also missing boolean schema support (I filed a PR to fix this at kogosoftwarellc/open-api#902).