Modularize #584
Draft
Modularize #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in order to move towards a more functional and modular architecture move state that previously was helt on Generator class to a context the idea behind this is to pass the context object around between internal units as well as plugin callbacks and all shared state would be managed on the context object ref #562
in order to completely remove and disincentivize use of class state in favor of OazapftsContext as a preparation for plugin architecture BREAKING CHANGE: ApiGenerator Class has been removed ref #572
just create a new context when needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hand in hand with the Plugin System i would like to refactor the codegen implementation to be more modular and follow a functional approach.
Target state:
ApiGeneratormight be moved to their dedicated file.ApiGeneratorref #554