invalid_grant status code should be 400
#561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freeduerinckx
force-pushed
the
invalid-grant-should-respond-with-400
branch
from
0595bad
to
f00c7a0
Compare
According to section 5.2 of rfc 6749 (https://tools.ietf.org/html/rfc6749#section-5.2) A server should respond with 400 in case of an invalid grant. The given grant is invalid and the client should give other data. A 401 is not applicable here because the client is required to give a suitable Authorization header field which doesn't make any sense if you are trying to acquire a grant authentication. According to sections 10.4.1 and 10.4.2 of rfc 2616 (https://tools.ietf.org/html/rfc2616#section-10.4.1)
freeduerinckx
force-pushed
the
invalid-grant-should-respond-with-400
branch
from
f00c7a0
to
a4f39fc
Compare
|
The docstring on the error should reference the RFC sections mentioned above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to section 5.2 of rfc 6749
(https://tools.ietf.org/html/rfc6749#section-5.2)
A server should respond with 400 in case of an invalid grant. The
given grant is invalid and the client should give other data.
A 401 is not applicable here because the client is required to give
suitable Authorization header field which doesn't make any sense if
you are trying to acquire a grant authentication.
According to sections 10.4.1 and 10.4.2 of rfc 2616
(https://tools.ietf.org/html/rfc2616#section-10.4.1)
WIP: these changes breaks downstream libs tests: