Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logging via OAUTH_DEBUG=true to log both request and response, in… #366

Merged
merged 4 commits into from
Mar 7, 2018

Conversation

pboling
Copy link
Member

@pboling pboling commented Mar 7, 2018

…cluding bodies of each

Add specs to test request, response, and all bodies get logged, and only when OAUTH_DEBUG=true

Fixes #214

Hat tip to lostisland/faraday#254

…cluding bodies of each

Add specs to test request, response, and all bodies get logged, and only when OAUTH_DEBUG=true
@pboling pboling added this to the 2.0.0 milestone Mar 7, 2018
@pboling pboling requested a review from josephpage March 7, 2018 03:49
@pboling pboling self-assigned this Mar 7, 2018
@pboling pboling requested review from xtagon and johaywood March 7, 2018 03:49
Copy link

@xtagon xtagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as the CI passes 👍

@pboling pboling merged commit e8ddad2 into master Mar 7, 2018
@pboling pboling deleted the pboling/214-log-the-right-body branch March 7, 2018 06:23
@pboling pboling added the in Changelog Has been added to Changelog label Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request in Changelog Has been added to Changelog
Projects
None yet
2 participants