Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(encoding): Handle invalid encoding #267

Closed
wants to merge 3 commits into from
Closed

fix(encoding): Handle invalid encoding #267

wants to merge 3 commits into from

Conversation

fjg
Copy link

@fjg fjg commented Aug 8, 2016

This is due to Faraday response.body which is set to ASCII-8BIT instead of (request header charset, i.e. UTF-8).
Seams related to a underlying adapter: see lostisland/faraday#139

…hich is set to ASCII-8BIT instead of UTF-8. Seams related to a underlying adapter: see lostisland/faraday#139
@coveralls
Copy link

coveralls commented Aug 8, 2016

Coverage Status

Coverage remained the same at 96.166% when pulling e4b4dfd on fjg:invalid_encoding into fb502c7 on intridea:master.

@coveralls
Copy link

coveralls commented Aug 8, 2016

Coverage Status

Coverage remained the same at 96.166% when pulling 48dc305 on fjg:invalid_encoding into fb502c7 on intridea:master.

@coveralls
Copy link

coveralls commented Aug 8, 2016

Coverage Status

Coverage remained the same at 96.166% when pulling b02401b on fjg:invalid_encoding into fb502c7 on intridea:master.

@sarojkh
Copy link

sarojkh commented Aug 16, 2018

The issue this PR is trying to solve seems to have been already solved by #271, and then rervamped by #380.

@josephpage This PR might as well be closed.

@pboling
Copy link
Member

pboling commented Aug 20, 2018

@sarojkh Thanks for reviewing!

@pboling pboling closed this Aug 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants