Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor revision for TC meeting 2024-02-28 #699

Merged
merged 50 commits into from Apr 9, 2024
Merged

Editor revision for TC meeting 2024-02-28 #699

merged 50 commits into from Apr 9, 2024

Conversation

tschmidtb51
Copy link
Contributor

@tschmidtb51 tschmidtb51 commented Feb 24, 2024 •
edited

tschmidtb51 and others added 30 commits January 30, 2024 22:03
@tschmidtb51
CVSS 4.0
c813a56 
- addresses parts of #652
- add CVSS v4 to JSON schema
@tschmidtb51
CVSS 4.0
75669a8 
- addresses parts of #652
- add CVSS v4.0 to referenced schemas
- add strict version of schema
@tschmidtb51
CVSS 4.0
6ba76ff 
- addresses parts of #652
- adopt test scripts to include CVSS 4.0
@tschmidtb51
CVSS 4.0
5117d27 
- addresses parts of #652
- add CVSS 4.0 to informative references
- add CVSS 4.0 to construction principles
@tschmidtb51
CVSS 4.0
d282368 
- addresses parts of #652
- add CVSS 4.0 to `/vulnerabilities[]/scores[]`
@tschmidtb51
CVSS 4.0
16530f9 
- addresses parts of #652, #341
- add invalid example for 6.1.7
- add valid examples for 6.1.7
@tschmidtb51
Tests
69532cd 
- addresses parts of #341
- add invalid examples for 6.1.7
- add valid examples for 6.1.7
@tschmidtb51
CVSS 4.0
02acf23 
- addresses parts of #652, #341
- add missing CVSS 4.0 reference in validator test script
@tschmidtb51
CVSS 4.0
6d35d3d 
- addresses parts of #652
- update the strict version to use `unevaluatedProperties` instead of `additionalProperties` which fails with `allOf`
@tschmidtb51
CVSS 4.0
2e36a29 
- addresses parts of #652
- use different vector to avoid `multiple` issue
@tschmidtb51
CVSS 4.0
7c64cab 
- addresses parts of #652
- address `multipleOf` issue by parsing floats as Decimal
- add valid example to show correctness
@tschmidtb51
CVSS 4.0
4140ce9 
- addresses parts of #652
- add CVSS 4.0 to Appendix C regarding size
@tschmidtb51
CVSS 4.0
35278f6 
- addresses parts of #652
- add CVRF-CSAF-conversion rule
@tschmidtb51
CVSS 4.0
efba9ae 
- addresses parts of #652, #341
- add invalid example for 6.1.8
- add valid examples for 6.1.8
- update test 6.1.8
@tschmidtb51
CVSS 4.0
740aa8f 
- addresses parts of #652, #341
- add invalid example for 6.1.9
- add valid examples for 6.1.9
- update test description 6.1.9
@tschmidtb51
CVSS 4.0
3032528 
- addresses parts of #652, #341
- add invalid examples for 6.1.10
- add valid examples for 6.1.10
- update test description 6.1.10
@tschmidtb51
CVSS 4.0
7506cd1 
- addresses parts of #652, #341
- add invalid examples for 6.2.19
- add valid examples for 6.2.19
- update test description 6.2.19
@tschmidtb51
CVSS 4.0
2f21663 
- addresses parts of #652, #341
- add invalid example for 6.3.1
- add valid example for 6.3.1
- update test description 6.3.1
@tschmidtb51
CVSS 4.0
dfc79b6 
- addresses parts of #652
- add test 6.3.12
- add invalid examples for 6.3.12
- add valid examples for 6.3.12
@tschmidtb51
CVSS 4.0
ce28043 
- addresses parts of #652, #341
- add valid example for 6.1.9 to trigger `multipleOf` issue
@tschmidtb51
CVSS 4.0
1c81028 
- addresses parts of #652
- correct wrong `/document/tracking/id`
@tschmidtb51
Merge pull request #688 from tschmidtb51/add-cvss-4.0
d0638d9 
Add CVSS 4.0
@tschmidtb51
References
ea1d449 
- fixes #684
- add RFC 8322 as informative reference
@tschmidtb51
BOM Link
1612c75 
- fixes #687
- correct namespace
@tschmidtb51
Editorial
9429813 
- update date
- update revision history
- update citation format
@tschmidtb51
Size limit
7aa5c24 
- addresses parts of #626
- update size limit and unit
@tschmidtb51
Artifacts
ae30854 
- generate artifacts for easier reading
@sthagen
Added bridge in the note on the increased size
05db3f8
@tschmidtb51 @sthagen
References
f756a72 
- fixes #684
- add RFC 8322 as informative reference
@tschmidtb51 @sthagen
BOM Link
13ec5b7 
- fixes #687
- correct namespace
@tschmidtb51
Correct Example 129
9a7cf53 
- resolves #589
- make each file appear only once in changes.csv
- update filenames to reflect suggested practice
@tschmidtb51
Markdown
c6e5a75 
- addresses parts of #629
- clearly state that GitHub-flavoured Markdown is allowed
@tschmidtb51
Markdown
8bfb626 
- addresses parts of #629
- explicitly mention fields that may contain Markdown
@tschmidtb51
Editorial
877ddd1 
- resolves #634
- correct broken link
@tschmidtb51
CSAF 2.0-2.1 converter
eb95b8d 
- addresses parts of #673
- add new conformance target CSAF 2.0 CSAF 2.1 converter
@tschmidtb51 tschmidtb51 added the csaf 2.1 csaf 2.1 work label Feb 24, 2024
@tschmidtb51 tschmidtb51 changed the title Editor revision 2024 02 28 Editor revision for TC meeting 2024-02-28 Feb 24, 2024
tschmidtb51 and others added 3 commits February 24, 2024 19:38
@tschmidtb51
Editorial
9c40e21 
- resolves #576
- add missing date in VEX-Justification reference
@tschmidtb51
Editorial
1ef57cb 
- resolves #578
- remove obsolete "is"
@sthagen
Nit
c41b0f2
sthagen
sthagen reviewed Feb 24, 2024
View reviewed changes
Copy link
Contributor

@sthagen sthagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks already good to me - I did not spot any obvious error in the 72 files.

sthagen
sthagen approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@sthagen sthagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@sthagen @tschmidtb51
Rendered delivery items matching editor revision 2024-02-28
49ff91a 
- amended the mapping helper files in etc to include the added section and example
- executed the rendering pipeline
- Note: the automated extraction of section and example counts for the mapping
  helpers was forgotten along the many changes during bootstrap
  TODO(sthagen) to restore this auto discovery

Co-authored-by: Thomas Schmidt <thomas.schmidt@bsi.bund.de>
Signed-off-by: Stefan Hagen <stefan@hagen.link>
tschmidtb51 added a commit to tschmidtb51/csaf that referenced this pull request Feb 27, 2024
@tschmidtb51
Editorial
1035bfe 
- addresses parts of oasis-tcs#652, oasis-tcs#699
- correct location of section separator
@tschmidtb51 tschmidtb51 mentioned this pull request Feb 27, 2024
Merged
@santosomar santosomar marked this pull request as ready for review March 27, 2024 09:23
@santosomar
Copy link
Contributor

santosomar commented Mar 27, 2024 •
edited

During the 2024-02-28, the TC discussed to allow another two weeks for review.

  • The TC should review the changes by the second week of March -- two weeks from the  Feb 2024 meeting (March 13th)
  • I have marked the PR as "ready for review" and changed it from its "draft" state.
  • I propose to do a quick discussion during the TC meeting today and merge the changes, if there are no objections. If quorum cannot be reached our accounted for, we can do a motion via email right after the meeting.

sthagen
sthagen approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@sthagen sthagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SLGTM 😁

@tschmidtb51 tschmidtb51 mentioned this pull request Mar 27, 2024
Open
@santosomar
Copy link
Contributor

Discussed during the CSAF TC monthly meeting on 2024-03-27. There was only a comment from Feng Cao about potential updates from the CVSS SIG. Those were informational. A motion will be put via email to merge this PR.

@santosomar
Copy link
Contributor

The motion to accept the Editor Revision as suggested in PR #699 https://github.com/oasis-tcs/csaf/pulls/699 into our master branch has passed. No objection was received and the motion automatically passed on 2024-04-03 20:00 UTC.

Also announced at:
https://groups.oasis-open.org/discussion/motion-for-699

@santosomar santosomar merged commit 2061cf8 into master Apr 9, 2024
10 checks passed
@sthagen sthagen deleted the editor-revision-2024-02-28 branch April 9, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sthagen sthagen sthagen approved these changes

@santosomar santosomar santosomar approved these changes

Assignees

@sthagen sthagen

@tschmidtb51 tschmidtb51

Labels
csaf 2.1 csaf 2.1 work
Projects
None yet
Milestone
No milestone
3 participants
@tschmidtb51 @santosomar @sthagen