[RHELC-1543] Update integrations tests for overridable config #1223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating the user_path_cli_priority int tests to test for the changes done in oamg#1208. The test had a small refactor to make it easier to read assert for multiple strings at once. Also removed the interrupt at the beginning to let the tool to process the changes.
r0x0d
added
no-changelog
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+92
to
+93
| "WARNING - You have passed either the RHSM password or activation key through both the command line and" | ||
| " the configuration file. We're going to use the command line values.", |
Check warning
Code scanning / CodeQL
Implicit string concatenation in a list Warning
|
/packit test --labels tier0 |
pr-watson
approved these changes
May 15, 2024
kokesak
requested changes
May 16, 2024
Comment on lines
+86
to
+93
| c2r_expect_index = c2r.expect( | ||
| [ | ||
| "DEBUG - Found username in /root/.convert2rhel.ini", | ||
| "DEBUG - Found password in /root/.convert2rhel.ini", | ||
| "DEBUG - Found activation_key in /root/.convert2rhel.ini", | ||
| "DEBUG - Found org in /root/.convert2rhel.ini", | ||
| "WARNING - You have passed either the RHSM password or activation key through both the command line and" | ||
| " the configuration file. We're going to use the command line values.", |
There was a problem hiding this comment.
Sadly this will not work as intended. It should return the index of the first string that it finds (https://pexpect.readthedocs.io/en/stable/api/pexpect.html?highlight=expect#pexpect.spawn.expect). With this we are not able to verify that the second line is found. So we need to call expect() multiple times to verify multiple strings appearing in the output
There was a problem hiding this comment.
Oh :(
Okay, I will revert the change
danmyway
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the user_path_cli_priority int tests to test for the changes done in #1208.
The test had a small refactor to make it easier to read assert for multiple strings at once. Also removed the interrupt at the beginning to let the tool to process the changes.
Jira Issues:
Checklist
[RHELC-]is part of the PR titleRelease Pendingif relevant