[RHELC-1540] Fix bug with duplicate packages check when running with Satellite offline #1219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pr-watson
added
enhancement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1219 +/- ##
==========================================
- Coverage 95.44% 95.42% -0.03%
==========================================
Files 54 54
Lines 4723 4700 -23
Branches 834 831 -3
==========================================
- Hits 4508 4485 -23
- Misses 132 133 +1
+ Partials 83 82 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
r0x0d
reviewed
May 13, 2024
convert2rhel/unit_tests/actions/system_checks/duplicate_packages_test.py
Outdated
Show resolved
Hide resolved
pr-watson
force-pushed
the
duplicate-packages-satellite-bug
branch
from
0e0df6f
to
6cb4bae
Compare
|
/packit test --labels tier0 |
pr-watson
added
tests-run-sanity
r0x0d
reviewed
May 15, 2024
pr-watson
force-pushed
the
duplicate-packages-satellite-bug
branch
from
49947de
to
3ed3f49
Compare
pr-watson
force-pushed
the
duplicate-packages-satellite-bug
branch
from
3ed3f49
to
5b154c6
Compare
hosekadam
reviewed
May 20, 2024
convert2rhel/unit_tests/actions/system_checks/duplicate_packages_test.py
Outdated
Show resolved
Hide resolved
hosekadam
reviewed
May 20, 2024
hosekadam
reviewed
May 20, 2024
convert2rhel/unit_tests/actions/system_checks/duplicate_packages_test.py
Show resolved
Hide resolved
hosekadam
reviewed
May 20, 2024
convert2rhel/unit_tests/actions/system_checks/duplicate_packages_test.py
Show resolved
Hide resolved
hosekadam
reviewed
May 20, 2024
convert2rhel/unit_tests/actions/system_checks/duplicate_packages_test.py
Show resolved
Hide resolved
Co-authored-by: Adam Hosek <hosek.adam@outlook.com>
pr-watson
force-pushed
the
duplicate-packages-satellite-bug
branch
from
3d1db1a
to
4a49abb
Compare
Merged
hosekadam
added
bug-fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds handlers for errors raised when running the DUPLICATE_PACKAGES check with Satellite on an offline system. On EL7 systems for this particular error case the return code is 0 and the output is [Errno -2] Name or service not known. while on EL8 the return code is 1 and the output is Failed to download metadata for repo [example repo]: Cannot download repomd.xml: Cannot download repodata/repomd.xml: All mirrors were tried.
For EL7 we check for that specific output and for EL8 we check the return code. Both cases raise a WARNING DUPLICATE_PACKAGE_CHECK_FAILED and inform the user we couldn't perform the check and recommend they ensure they can access all repos enabled on their system and re-run convert2rhel or check for duplicate packages themselves. This way we don't hinder the conversion for offline systems on satellite while informing them how to remediate the failure.
Jira Issues:
Checklist
[RHELC-]is part of the PR titleRelease Pendingif relevant