Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RHELC-1303, RHELC-1527, RHELC-1557] Enhance exit code testing #1206

Merged
merged 2 commits into from
May 22, 2024
Merged

[RHELC-1303, RHELC-1527, RHELC-1557] Enhance exit code testing #1206

merged 2 commits into from
May 22, 2024

Conversation

kokesak
Copy link
Member

@kokesak kokesak commented May 3, 2024 •
edited

This PR fixes exit code asserts in the integration tests. Also adds one new integration test case with broken rollback scenario.
Jira Issues:

Checklist

  • PR has been tested manually in a VM (either author or reviewer)
  • Jira issue has been made public if possible
  • [RHELC-1303] is part of the PR title
  • GitHub label has been added to help with Release notes
  • PR title explains the change from the user's point of view
  • Code and tests are documented properly
  • The commits are squashed to as few commits as possible (without losing data)
  • When merged: Jira issue has been updated to Release Pending if relevant

@codecov Codecov
Copy link

codecov bot commented May 3, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.54%. Comparing base (0bfc9ca) to head (efb155c).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1206   +/-   ##
=======================================
  Coverage   95.54%   95.54%           
=======================================
  Files          54       54           
  Lines        4715     4715           
  Branches      829      829           
=======================================
  Hits         4505     4505           
  Misses        127      127           
  Partials       83       83
Flag Coverage Δ
centos-linux-7 90.68% <ø> (ø)
centos-linux-8 91.62% <ø> (ø)
centos-linux-9 91.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kokesak kokesak added no-changelog If it should be excluded from changelog or Release notes. Such as infra, reverted PRs, etc. tests-run-tier0 PR ready to run the essential test suit. Equivalent to `/packit test --labels tier0`. labels May 3, 2024
@has-bot
Copy link
Member

has-bot commented May 3, 2024

/packit test --labels tier0

Comment generated by an automation.

@kokesak
Copy link
Member Author

kokesak commented May 3, 2024

/packit test --labels tier0

@kokesak
Copy link
Member Author

kokesak commented May 6, 2024

/packit test --labels tier0

@kokesak
Copy link
Member Author

kokesak commented May 6, 2024

/packit test --labels tier0

@kokesak
Copy link
Member Author

kokesak commented May 6, 2024

/packit test --labels tier0

@kokesak
Copy link
Member Author

kokesak commented May 7, 2024

/packit build

@kokesak
Copy link
Member Author

kokesak commented May 7, 2024

/packit test --labels tier0

@kokesak
Copy link
Member Author

kokesak commented May 7, 2024

/packit test

@kokesak
Copy link
Member Author

kokesak commented May 7, 2024

/packit test --labels tier0

@kokesak
Copy link
Member Author

kokesak commented May 7, 2024

/packit test --labels tier0

@kokesak
Copy link
Member Author

kokesak commented May 9, 2024

/packit test --labels tier0

@kokesak
Copy link
Member Author

kokesak commented May 9, 2024

/packit retest-failed

@r0x0d
Copy link
Member

r0x0d commented May 9, 2024

/packit test --labels tier0

@kokesak
Copy link
Member Author

kokesak commented May 13, 2024

/packit test --labels tier0

@kokesak
Copy link
Member Author

kokesak commented May 15, 2024

@oamg/conversions-qe please review

@r0x0d
Copy link
Member

r0x0d commented May 15, 2024

We just merged the exit code as 1 in case of failure. Let's rebase this one to see if the tests might contain some hidden failures

@kokesak
Copy link
Member Author

kokesak commented May 15, 2024

We just merged the exit code as 1 in case of failure. Let's rebase this one to see if the tests might contain some hidden failures

Ok, I'll rebase and re-run the tests

@kokesak
Copy link
Member Author

kokesak commented May 16, 2024

/packit test

danmyway
danmyway approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@danmyway danmyway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, go ahead and merge, if tests pass.

@kokesak
Copy link
Member Author

kokesak commented May 16, 2024

/packit test

@kokesak kokesak mentioned this pull request May 17, 2024
Merged
8 tasks
@kokesak
Copy link
Member Author

kokesak commented May 20, 2024

/packit test

@danmyway danmyway changed the title [RHELC-1303] Enhance exit code testing [RHELC-1303, RHELC-1527] Enhance exit code testing May 21, 2024
danmyway
danmyway requested changes May 21, 2024
View reviewed changes
Copy link
Member

@danmyway danmyway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor things uncovered by the adjustments.

tests/integration/tier0/non-destructive/rollback-handling/test_rollback_handling.py Outdated Show resolved Hide resolved
tests/integration/tier1/destructive/excluded-packages-removed/test_excluded_pkgs_removed.py Show resolved Hide resolved
@kokesak
Copy link
Member Author

kokesak commented May 21, 2024

/packit test

@kokesak kokesak changed the title [RHELC-1303, RHELC-1527] Enhance exit code testing [RHELC-1303, RHELC-1527, RHELC-1557] Enhance exit code testing May 21, 2024
@kokesak
Copy link
Member Author

kokesak commented May 21, 2024

/packit test

@kokesak kokesak force-pushed the tests-exit-code-2 branch 2 times, most recently from 94d3ae7 to d9c8cf5 Compare May 22, 2024 06:05
@kokesak kokesak added tests-run-all Run the full test suite. Equivalent to `/packit test`. and removed tests-run-tier0 PR ready to run the essential test suit. Equivalent to `/packit test --labels tier0`. labels May 22, 2024
@has-bot
Copy link
Member

has-bot commented May 22, 2024

/packit test

Comment generated by an automation.

@kokesak
Copy link
Member Author

kokesak commented May 22, 2024

/packit test

@kokesak kokesak requested a review from danmyway May 22, 2024 08:15
@kokesak @danmyway
Add fail during rollback integation test case
efb155c 
Reference tickets:
https://issues.redhat.com/browse/RHELC-1275
https://issues.redhat.com/browse/RHELC-1301

Co-authored-by: Daniel Diblik <8378124+danmyway@users.noreply.github.com>
@kokesak
Copy link
Member Author

kokesak commented May 22, 2024

/packit test

danmyway
danmyway approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@danmyway danmyway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks

@kokesak kokesak merged commit 972f6b6 into oamg:main May 22, 2024
41 checks passed
@kokesak
Copy link
Member Author

kokesak commented May 22, 2024

Looking good, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r0x0d r0x0d r0x0d left review comments

@danmyway danmyway danmyway approved these changes

Assignees
No one assigned
Labels
no-changelog If it should be excluded from changelog or Release notes. Such as infra, reverted PRs, etc. tests-run-all Run the full test suite. Equivalent to `/packit test`.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kokesak @has-bot @r0x0d @danmyway