Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autodocs boilerplate #1108

Merged
merged 1 commit into from
May 23, 2024
Merged

Add autodocs boilerplate #1108

merged 1 commit into from
May 23, 2024

Conversation

bookwar
Copy link
Contributor

@bookwar bookwar commented Feb 22, 2024

This patch adds autodocs skeleton without adding any automation to generate the docs.

Checklist

  • [N/A] PR has been tested manually in a VM (either author or reviewer)
  • [N/A] Jira issue has been made public if possible
  • [N/A] [RHELC-] is part of the PR title
  • GitHub label has been added to help with Release notes
  • PR title explains the change from the user's point of view
  • Code and tests are documented properly
  • The commits are squashed to as few commits as possible (without losing data)
  • When merged: Jira issue has been updated to Release Pending if relevant

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.45%. Comparing base (9da391f) to head (2ca0c31).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1108   +/-   ##
=======================================
  Coverage   95.45%   95.45%           
=======================================
  Files          54       54           
  Lines        4733     4733           
  Branches      836      836           
=======================================
  Hits         4518     4518           
  Misses        132      132           
  Partials       83       83           
Flag Coverage Δ
centos-linux-7 90.61% <ø> (ø)
centos-linux-8 91.55% <ø> (ø)
centos-linux-9 91.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docs/source/conf.py Outdated Show resolved Hide resolved
Comment on lines +4 to +13
# You can set these variables from the command line, and also
# from the environment for the first two.
SPHINXOPTS ?=
SPHINXBUILD ?= sphinx-build
SOURCEDIR = source
BUILDDIR = build

# Put it first so that "make" without argument is like "make help".
help:
@$(SPHINXBUILD) -M help "$(SOURCEDIR)" "$(BUILDDIR)" $(SPHINXOPTS) $(O)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also just in general would be great to have this generated in a container so it's reproducible on all machines

https://hub.docker.com/r/sphinxdoc/sphinx

@bookwar bookwar added the tests-skip This PR does not require integration tests to be run. label May 15, 2024
@has-bot
Copy link
Member

has-bot commented May 15, 2024

This PR does not require integration tests to be run.


Comment generated by an automation.

@bookwar bookwar added no-changelog If it should be excluded from changelog or Release notes. Such as infra, reverted PRs, etc. documentation Improvements or additions to documentation labels May 16, 2024
This patch adds the initial setup if the Python Sphinx Autodocs.

We use autosummary extension to generate recursively the tree of all
modules, classes and functions. Then we additionally add two pages
(actions.rst and pkgmanager.rst) to show the possibility to add custom
content to the autogenerated documentation.

To build the docs you need

python3-sphinx
python3-sphinx-autodoc-typehints

installed on the environment (via dnf or pip)
@bookwar bookwar marked this pull request as ready for review May 22, 2024 15:32
Copy link
Member

@Venefilyn Venefilyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works for you I don't mind merging it. I can figure out the Container later

@bookwar bookwar merged commit 1c4a53c into oamg:main May 23, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation no-changelog If it should be excluded from changelog or Release notes. Such as infra, reverted PRs, etc. tests-skip This PR does not require integration tests to be run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants