Skip to content

Commit

Permalink
Decisions on 2.0 todos
Browse files Browse the repository at this point in the history
  • Loading branch information
200sc committed Jan 21, 2018
1 parent 52c7cd6 commit bb37e2f
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 9 deletions.
3 changes: 0 additions & 3 deletions event/strings.go
Expand Up @@ -22,9 +22,6 @@ const (
// Enter : the beginning of every logical frame.
// Payload: (int) frames passed since this scene started
Enter = "EnterFrame"
//
// Consider moving the below to different packages before 2.0 release
//
// AnimationEnd: Triggered on animations CIDs when they loop from the last to the first frame
// Payload: nil
AnimationEnd = "AnimationEnd"
Expand Down
2 changes: 1 addition & 1 deletion render/line.go
Expand Up @@ -12,7 +12,7 @@ import (
// Our current concept of thickness expands out in both directions,
// so it's impossible to draw a even-pixel thick line. This is probably
// okay for an easy syntax like this but we might want to add in a
// "Line constructor" type object like our ray-casters in release/2.0.0
// "Line constructor" type object like our ray-casters
// so this behavior can be customized, i.e.-- if you take thickness as
// pixel thickness, do you expand out left or right, or center, and how
// are ties broken, etc. That would also help prevent the number of
Expand Down
1 change: 0 additions & 1 deletion render/polygon.go
Expand Up @@ -46,7 +46,6 @@ func NewPolygon(points ...floatgeom.Point2) (*Polygon, error) {
}

// UpdatePoints resets the points of this polygon to be the passed in points
// Todo 2.0: Take in a variadic set instead of a slice
func (pg *Polygon) UpdatePoints(points ...floatgeom.Point2) error {
if len(points) < 3 {
return oakerr.InsufficientInputs{AtLeast: 3, InputName: "points"}
Expand Down
4 changes: 0 additions & 4 deletions render/sprite_test.go
Expand Up @@ -26,10 +26,6 @@ const (
fuzzCt = 10
)

// Todo for color boxes, and things that take w/h --
// return an error for negative (or 0 in some cases) w / h. The engine assumes
// right now that the inputs will be valid, which is a mistake
// this is a breaking change for 2.0
func TestColorBoxFuzz(t *testing.T) {
for i := 0; i < fuzzCt; i++ {
w := widths.Poll()
Expand Down

0 comments on commit bb37e2f

Please sign in to comment.