Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix history api #266

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix history api #266

wants to merge 1 commit into from

Conversation

Ciki
Copy link
Contributor

@Ciki Ciki commented Feb 29, 2016

handle only own history stack & make history api actually work

handle only own history stack & make history api actually work
@o5
Copy link
Owner

o5 commented Apr 28, 2016

Pokud to ma resit neprijemnej problem, nefunkcniho tlacitka BACK, tak mi to neresi :/ To kdysi urcite fungovalo, ale mam pocit, ze se to rozbilo, kdyz nekdo "fixoval" (a ja mergoval) fungovani na pri vice gridu na jedne strane :/

@Ciki
Copy link
Contributor Author

Ciki commented Apr 29, 2016

Nie, riesit to ma najma to, aby sa grido nesnazilo handlovat VSETKY zmeny stavov, ale len tie svoje (params.grido=true).
Teda ak si dobre spominam :)

@o5
Copy link
Owner

o5 commented Apr 29, 2016

Muzes prosim popsat, jak to zreprodukovat? Diky

var state = $.data(document, this.grido.name + '-query') || '',
query = window.location.search;

if (state !== query) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

staci, ked bude state = '' a query lubovolny string (teda niekde mimo grido niekto nastavi hash), tak grido robi request na refresh. Aspon ak si dobre pamatam, tak toto som riesil

@o5
Copy link
Owner

o5 commented Apr 29, 2016

teda niekde mimo grido niekto nastavi hash

To prave nedokazu nasimulovat :/ Pouzivas nette.ajax.js plugin? Ten ajax request ze serveru musi vracet payload.grido, jinak se grido success handler nespusti.

@Ciki
Copy link
Contributor Author

Ciki commented Apr 29, 2016

Ano, pouzivam.
success handler sa spusta spravne. Problem je, ze v onPopState uz nekontrolujes ci stav, kt. chces popnut, si ulozil grido alebo nejaka ina komponenta.. cize success handler sa spusti napr. po filtrovani cez grido ale v location.hash si predtym mohla uplne ina komponenta ulozit svoj stav .. a grido ho smz nevie refreshnut.. je to zrozumitelne, co pisem?

@o5 o5 added the CLIENT-SIDE label May 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants