Flatten branching loop in b_plane calc #275
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for working GitHub actions unnecessarily! I'll look this over in the morning to see what invariants I'm violating. |
src/cosmic/bplane.rs
Outdated
| return Ok((total_dv, b_plane)); | ||
| let (norm, dv) = match ltof_err { | ||
| None => { | ||
| let v = Vector2::new(br_err, bt_err); |
There was a problem hiding this comment.
Oh, good find! The B-Plane Jacobian is indeed BR, BT, LTOF. That said, I think this should be fixed in the Jacobian() function so it returns BT, BR, LTOF as does the Jacobian2 function and as the documentation says.
https://rustdoc.nyxspace.com/src/nyx_space/cosmic/bplane.rs.html#140-152
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Effects
This is mostly a stylistic change, feel free to disregard. Helps unify similar code across two branches
If this is a new feature or a bug fix ...
issue-xyzwherexyzis the number of the issue.If this change adds or modifies a validation case
VALIDATION.mdfile with the new error data between nyx and GMAT.