Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): restore project.json generation #842

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mhdubose
Copy link

Update generator to create project.json but omit targets if they can be inferred by Nx Crystal

Copy link

sonarcloud bot commented Mar 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@AgentEnder AgentEnder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideallistically we'd update the other generators that look for project configurations etc and fix them up s.t. they work better with crystal (aka inference). Plugins can infer full projects, which is what we are doing here, its just some devkit methods won't be able to find them.

For a short term fix though, this will work well.

Copy link

nx-cloud bot commented Apr 1, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 16da34f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


🟥 Failed Commands
nx run-many --target=e2e --all --output-style=stream
✅ Successfully ran 5 targets

Sent with 💌 from NxCloud.

@md-owes
Copy link

md-owes commented May 6, 2024

since this PR is still waiting to be merged even after a month, folks like me who cannot wait further can downgrade to the previous version (i.e. 2.1.2). For beginners, you need to have the following in your package.json

"devDependencies": {
    "@nx-dotnet/core": "2.1.2"
    }

and then do npm i. Now it should work.

@mhdubose
Copy link
Author

any updates @AgentEnder on when we can get this in as a temporary fix, or a better long term fix is coming?

Copy link

sonarcloud bot commented May 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants