New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): restore project.json generation #842
base: master
Are you sure you want to change the base?
Conversation
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideallistically we'd update the other generators that look for project configurations etc and fix them up s.t. they work better with crystal (aka inference). Plugins can infer full projects, which is what we are doing here, its just some devkit methods won't be able to find them.
For a short term fix though, this will work well.
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 16da34f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution
✅ Successfully ran 5 targets
Sent with 💌 from NxCloud. |
since this PR is still waiting to be merged even after a month, folks like me who cannot wait further can downgrade to the previous version (i.e. 2.1.2). For beginners, you need to have the following in your package.json
and then do |
any updates @AgentEnder on when we can get this in as a temporary fix, or a better long term fix is coming? |
Quality Gate passedIssues Measures |
Update generator to create
project.json
but omit targets if they can be inferred by Nx Crystal