enable flags for ac3 and hevc codecs #64
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flags enable_ac3_eac3_audio_demuxing and enable_hevc_demuxing needed to be enabled on Chromium side in order to be working with 3rd-party built ffmpeg libraries for AC3 and HEVC codecs. fixed nwjs/nw.js#5653
GnorTech
force-pushed
the
nw20
branch
4 times, most recently
from
997b872
to
d804b23
Compare
GnorTech
pushed a commit
that referenced
this pull request
Jan 29, 2017
This fixes the problem of Enterprise default policies sometimes overwriting Active Directory-set policies. BUG=683150 Review-Url: https://codereview.chromium.org/2641343002 Cr-Commit-Position: refs/heads/master@{#445389} (cherry picked from commit 877b211) Review-Url: https://codereview.chromium.org/2656663002 . Cr-Commit-Position: refs/branch-heads/2987@{#64} Cr-Branched-From: ad51088-refs/heads/master@{#444943}
GnorTech
force-pushed
the
nw20
branch
3 times, most recently
from
961e670
to
e9d818b
Compare
rogerwang
force-pushed
the
nw20
branch
8 times, most recently
from
9943f9c
to
0d73593
Compare
rogerwang
force-pushed
the
nw20
branch
3 times, most recently
from
8169d48
to
699e965
Compare
rogerwang
pushed a commit
that referenced
this pull request
Mar 11, 2017
TBR=dtrainor@chromium.org BUG=698321 Review-Url: https://codereview.chromium.org/2729623007 Cr-Commit-Position: refs/heads/master@{#454946} (cherry picked from commit 18aa717) Review-Url: https://codereview.chromium.org/2737833002 . Cr-Commit-Position: refs/branch-heads/3029@{#64} Cr-Branched-From: 939b32e-refs/heads/master@{#454471}
GnorTech
pushed a commit
that referenced
this pull request
Apr 26, 2017
This CL updates the fixed font size from the Appearance section reliably. (It was previously working depending on which settings page had been visited). Also, updates the UI to remove the font size on the example of the fixed font size. BUG=671562 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2817243003 Cr-Commit-Position: refs/heads/master@{#465054} (cherry picked from commit b7cd6a5) Review-Url: https://codereview.chromium.org/2830883002 . Cr-Commit-Position: refs/branch-heads/3071@{#64} Cr-Branched-From: a106f0a-refs/heads/master@{#464641}
GnorTech
pushed a commit
that referenced
this pull request
Aug 5, 2017
Unsubscribe the WebTextfieldTouchBarController from the notification center when it's deallocated or the window it's observing is closed. (cherry picked from commit 33fe231) Bug: 747713 Change-Id: I9d3543775fadc9fda31f6de83c1b962218ce0a30 Reviewed-on: https://chromium-review.googlesource.com/583929 Commit-Queue: Sarah Chan <spqchan@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#489119} Reviewed-on: https://chromium-review.googlesource.com/587288 Reviewed-by: Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#64} Cr-Branched-From: ff259ba-refs/heads/master@{#488528}
GnorTech
pushed a commit
that referenced
this pull request
Sep 14, 2017
This CL avoid calling PerformNavigation on the delegate when it is null. It also makes the SigninViewController's delegate private to avoid it being accessed by other classes and exposing it to similar crashes. TBR=msarda@chromium.org (cherry picked from commit c4d3dc1) Bug: 758830 Change-Id: Ic778de6957115855273e6137721b0c0ace1315a6 Reviewed-on: https://chromium-review.googlesource.com/647889 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#499929} Reviewed-on: https://chromium-review.googlesource.com/655300 Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#64} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
GnorTech
pushed a commit
that referenced
this pull request
Oct 27, 2017
TBR=vasilii@chromium.org (cherry picked from commit 1009ba6) Bug: 774516 Change-Id: I17344d16d835a9db9daf1c87824ea9e40ec38baa Reviewed-on: https://chromium-review.googlesource.com/721544 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by: Tatiana Gornak <melandory@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#509366} Reviewed-on: https://chromium-review.googlesource.com/727932 Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#64} Cr-Branched-From: adb61db-refs/heads/master@{#508578}
rogerwang
pushed a commit
that referenced
this pull request
Jan 29, 2018
This is guarded behind a field trial, and is the last killswitch option. Bug: 781189 Change-Id: I22a25ff6a2629ca8b59aef727c54e2f491cb4771 Reviewed-on: https://chromium-review.googlesource.com/872074 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#530449}(cherry picked from commit 0dc72f9) Reviewed-on: https://chromium-review.googlesource.com/884241 Reviewed-by: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#64} Cr-Branched-From: bc084a8-refs/heads/master@{#530369}
GnorTech
pushed a commit
that referenced
this pull request
Mar 20, 2018
This cl updates the following views and behaviors in Keyboard Shortcut Viewer (KSV). 1. Remove the start search page. 2. Add Esc and Back key supports and update behavior with Backspace key. 3. Unbold text in no search results page. 4. Make the search bar 2px longer at both sides to align with text. 5. Update strings and tooltips of buttons. 6. Make the window 32px wider in order to put all shortcuts in one line. TBR=afakhry@chromium.org Bug: 768932 Test: Tested on device. Change-Id: Ief361b80b8326dfd8b3aea1b0cd17a42040be95d Reviewed-on: https://chromium-review.googlesource.com/942687 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#540372}(cherry picked from commit 626002f) Reviewed-on: https://chromium-review.googlesource.com/953031 Reviewed-by: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#64} Cr-Branched-From: 66afc5e-refs/heads/master@{#540276}
rogerwang
pushed a commit
that referenced
this pull request
Apr 25, 2018
TBR=dimu@chromium.org Change-Id: Ic26b00ac08ff7625fdbcfb749c94e17a89c8d7d1 Reviewed-on: https://chromium-review.googlesource.com/1015822 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#64} Cr-Branched-From: 9ef2aa8-refs/heads/master@{#550428}
rogerwang
pushed a commit
that referenced
this pull request
Jun 19, 2018
Bug: 829141, 847681 Change-Id: I6679e700049fb13d94322a4e8b0f87bc1310fe9e Reviewed-on: https://chromium-review.googlesource.com/1077677 Reviewed-by: Victor Costan <pwnall@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#562708}(cherry picked from commit 10cc957) Reviewed-on: https://chromium-review.googlesource.com/1081169 Reviewed-by: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#64} Cr-Branched-From: 010ddcf-refs/heads/master@{#561733}
GnorTech
pushed a commit
that referenced
this pull request
Aug 4, 2018
This CL replaces the "open new tab" animation from the BVC for UIRefresh. The animation itself is implemented inside an animation view which is inserted at the front of the BVC's content area; this will put the animation behind the bottom toolbar (or behind the toolbar in landscape). To avoid too much refactoring, this CL uses most of the setup code for the existing animation. To patch a visual glitch with that code, a snapshot of the top toolbar is inserted into the content area while the animation is running. Bug: 851872 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I12cb1805d6123ae0cdebcc7ce739f8ce51e3cfca Reviewed-on: https://chromium-review.googlesource.com/1143394 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#576830}(cherry picked from commit aad2c85) Reviewed-on: https://chromium-review.googlesource.com/1149780 Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#64} Cr-Branched-From: 271eaf5-refs/heads/master@{#576753}
rogerwang
pushed a commit
that referenced
this pull request
Sep 15, 2018
This CL adds the user's e-mail address and profile photo to the password prompt page at the beginning of the setup flow. This is a security requirement as it makes it clear to users what password that they should enter. Additionally, this CL adds a "cancel" button to this page. Note that there are various styling/CSS changes which still need to be made so that this page matches the mocks. TBR=khorimoto@google.com (cherry picked from commit a83fb6d) Bug: 878643, 824568 Change-Id: I59e75f73c310ea5f275b844268b70fa2e47af72f Reviewed-on: https://chromium-review.googlesource.com/1198564 Reviewed-by: Tommy Li <tommycli@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#588186} Reviewed-on: https://chromium-review.googlesource.com/1208452 Reviewed-by: Jeremy Klein <jlklein@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#64} Cr-Branched-From: 79f7c91-refs/heads/master@{#587811}
rogerwang
pushed a commit
that referenced
this pull request
Oct 31, 2018
Update the multi-device setup flow button bar to include the following buttons: Back, Cancel, Forward. Set the buttons on each page to conform to the following specs (sans padding): https://drive.google.com/file/d/1UqHV67OrdGT0_G0L98nV5IVr26OkHu9F/view. Screenshots with this patch applied: start screen: https://drive.google.com/open?id=1QlWKjesaBpt0ZtNQ_vONBqu1czUWiezz start screen (OOBE): https://drive.google.com/open?id=1kh9UNYjLaSbP-zE0U89sniZSb9Sbhk8fMw password screen: https://drive.google.com/open?id=1olKePztZ9pqxPHupVCdrwEBZ1pyfzLA_ success screen: https://drive.google.com/open?id=1zpZfnowdpOvge8nteqsjBHuUin_I9HgW Bug: 889574 Change-Id: I7a0834b58b6f2458e5ab6641aa5b323cb5fc32fe Tested: Manual; ./out/Default/browser_tests --gtest_filter=*MultiDevice* Reviewed-on: https://chromium-review.googlesource.com/c/1254760 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#599737}(cherry picked from commit 8057370) Reviewed-on: https://chromium-review.googlesource.com/c/1284444 Reviewed-by: Jeremy Klein <jlklein@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#64} Cr-Branched-From: 4226ddf-refs/heads/master@{#599034}
rogerwang
pushed a commit
that referenced
this pull request
Dec 18, 2018
Bug: 884020 Change-Id: I056a5a830c8ca5821d6ca3338372ee27702c0ff9 Reviewed-on: https://chromium-review.googlesource.com/c/1355308 Commit-Queue: Stuart Langley <slangley@chromium.org> Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#613421}(cherry picked from commit adefd8b) Reviewed-on: https://chromium-review.googlesource.com/c/1362487 Reviewed-by: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#64} Cr-Branched-From: d897fb1-refs/heads/master@{#612437}
rogerwang
pushed a commit
that referenced
this pull request
Feb 10, 2019
A few third-party packages mistakenly provide their localized strings for Norwegian with the incorrect 'no' locale tag (which represents a macro language, not a real one), instead of 'nb', the expected value. As such, these strings were omitted from the build and missing from APKs and bundles. This fixes the issue by ensuring that 'no' strings are recognized as 'nb' ones, if the package provides them. This CL thus adds 'nb' strings for the following 13 string resources in the Monochrome bundle: hats_lib_close_button_description hats_lib_default_prompt_title hats_lib_default_star_rating_bar_description hats_lib_default_thank_you hats_lib_next hats_lib_none_of_the_above hats_lib_open_text_hint hats_lib_open_text_no_pii hats_lib_prompt_no_thanks hats_lib_prompt_take_our_survey hats_lib_submit hats_lib_survey_page_number hats_lib_thank_you_followup_message + Disable pylint warnings properly now that of presubmit scripts have been fixed to parse the line-too-long directives properly [1] [1] https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1396094 BUG=920960 R=agrieve@chromium.org,benmason@chromium.org,estevenson@chromium.org,yfriedman@chromium.org Change-Id: Ied74827c2e53c81f165b2fbcaec9f35d7e893290 Reviewed-on: https://chromium-review.googlesource.com/c/1437174 Reviewed-by: Andrew Grieve <agrieve@chromium.org> Commit-Queue: David Turner <digit@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#626341}(cherry picked from commit 1a5082d) Reviewed-on: https://chromium-review.googlesource.com/c/1446191 Reviewed-by: David Turner <digit@chromium.org> Cr-Commit-Position: refs/branch-heads/3683@{#64} Cr-Branched-From: e510299-refs/heads/master@{#625896}
rogerwang
pushed a commit
that referenced
this pull request
Mar 24, 2019
TBR=govind@chromium.org Change-Id: Ifd00027394e08546c5ba19e23d21d788438dbf6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519100 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#64} Cr-Branched-From: d4a8972-refs/heads/master@{#638880}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flags enable_ac3_eac3_audio_demuxing and enable_hevc_demuxing needed
to be enabled on Chromium side in order to be working with 3rd-party
built ffmpeg libraries for AC3 and HEVC codecs.
fixed nwjs/nw.js#5653