Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dispatch restored event before minimized/maximinized/fullscreen #52

Open
wants to merge 2 commits into
base: nw14
Choose a base branch
from
Open

dispatch restored event before minimized/maximinized/fullscreen #52

wants to merge 2 commits into from

Conversation

ghostoy
Copy link
Member

@ghostoy ghostoy commented Nov 14, 2016

rogerwang pushed a commit that referenced this pull request Dec 5, 2016
@jrummell-chromium
Merge "EME: Update MediaKeyMessageEvent to match spec"
ab838c4 
MediaKeyMessageEventInit is now required for the constructor.

BUG=666869
TEST=W3C EME test mentioned in the bug no longer fails.

Review-Url: https://codereview.chromium.org/2514933002
Cr-Commit-Position: refs/heads/master@{#433323}
(cherry picked from commit 23ca36a)

Review URL: https://codereview.chromium.org/2518213002 .

Cr-Commit-Position: refs/branch-heads/2924@{#52}
Cr-Branched-From: 3a87aec-refs/heads/master@{#433059}
GnorTech pushed a commit that referenced this pull request Jan 29, 2017
Implement Crash Handle API
5b4745e 
This patch implements basical feature for crash handle API.
The feature like 'render processs keep crashing after crash is handled' hasn't implemented.

BUG=666106

Review-Url: https://codereview.chromium.org/2630473004
Cr-Commit-Position: refs/heads/master@{#445256}
(cherry picked from commit 6e10ee5)

Review-Url: https://codereview.chromium.org/2651743006 .
Cr-Commit-Position: refs/branch-heads/2987@{#52}
Cr-Branched-From: ad51088-refs/heads/master@{#444943}
rogerwang pushed a commit that referenced this pull request Mar 11, 2017
Add a 1px border stroke to the shelf button active app indicator.
c4f321b 
BUG=670970

Review-Url: https://codereview.chromium.org/2724403005
Cr-Commit-Position: refs/heads/master@{#454741}
(cherry picked from commit 7367db2)

Review-Url: https://codereview.chromium.org/2736973003 .
Cr-Commit-Position: refs/branch-heads/3029@{#52}
Cr-Branched-From: 939b32e-refs/heads/master@{#454471}
GnorTech pushed a commit that referenced this pull request Apr 26, 2017
@mitoshima
Do not hide shadow underlay for max/fullscreen state even if the clie…
4d5dad8 
…nt disables the shadow.

During the state transition, ARC preserves windows being deleted,
however the main window is deleted (thus, window frame is empty) which disables the shadow.

BUG=711514
TEST=covered by unit tests.
 manual. Instal & start "Clash Royal", then F4 to toggle fullscreen.

Review-Url: https://codereview.chromium.org/2820493004
Cr-Commit-Position: refs/heads/master@{#464819}
(cherry picked from commit ae72f92)

Review-Url: https://codereview.chromium.org/2821963002 .
Cr-Commit-Position: refs/branch-heads/3071@{#52}
Cr-Branched-From: a106f0a-refs/heads/master@{#464641}
GnorTech pushed a commit that referenced this pull request Aug 5, 2017
@JinsukKim
Consume mouse button events on toolbar
2011da0 
A regression was letting mouse button click events on toolbar
to be passed down to content layer, and causing the content
hidden behind the toolbar react to the events as well, while
they should have triggered corresponding action on the toolbar
only. This CL stop the leak.

BUG=740855
NOTRY=true
NOPRESUBMIT=true
TBR=jinsukkim@chromium.org

(cherry picked from commit ddd3b95)

Change-Id: I3e0e3ede01ba73d589b3d3e3fa3a55b2577c0957
Reviewed-on: https://chromium-review.googlesource.com/582053
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#489123}
Reviewed-on: https://chromium-review.googlesource.com/585509
Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#52}
Cr-Branched-From: ff259ba-refs/heads/master@{#488528}
GnorTech pushed a commit that referenced this pull request Sep 14, 2017
[Merge to M62] Commit minimal migration status to local state prefs
755f160 
Commit minimal migration status to local state PrefService.
Introduces a CommitPendingWrite function with a callback to be sure that
prefs landed on disk.

BUG=747907
TBR=pmarko@chromium.org

(cherry picked from commit e1f238f)

Change-Id: I565ffbae7b8a1e934875101012c39c8a9841a139
Reviewed-on: https://chromium-review.googlesource.com/647454
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#499693}
Reviewed-on: https://chromium-review.googlesource.com/653639
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#52}
Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
GnorTech pushed a commit that referenced this pull request Oct 27, 2017
@agrieve
Add new limits for extra field, updated test file.
f9a91c4 
TBR=scottkirkwood@chromium.org

(cherry picked from commit 8c0020b)

Bug: 775160
Change-Id: Ic0f2a818386c78cf7b610035f7841f08e5477ab9
Reviewed-on: https://chromium-review.googlesource.com/723783
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Commit-Queue: Scott Kirkwood <scottkirkwood@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#509491}
Reviewed-on: https://chromium-review.googlesource.com/725526
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#52}
Cr-Branched-From: adb61db-refs/heads/master@{#508578}
rogerwang pushed a commit that referenced this pull request Jan 29, 2018
@stevenjb
VPN: Do not share configured VPNs
f3e1141 
VPN configurations were never shared in the non Settings based UI.
We should preserve that behavior in the new UI. (The current behavior
is completely wrong and always shares VPN configurations even when
they require certificates).

TBR=stevenjb@chromium.org

(cherry picked from commit b08867e)

Bug: 798924
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I4470a77b8f4f36e0f46aba5505eafd96fb0ca799
Reviewed-on: https://chromium-review.googlesource.com/876933
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Kevin Cernekee <cernekee@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#531008}
Reviewed-on: https://chromium-review.googlesource.com/882551
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#52}
Cr-Branched-From: bc084a8-refs/heads/master@{#530369}
GnorTech pushed a commit that referenced this pull request Mar 20, 2018
VR: Add java-side plumbing for updating GVR Keyboard
869f88f 
Note that this path is not exercised yet.

Bug: 799584
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I45f34d54eabcbd539c17d3d87ba8c029489a0f28
Reviewed-on: https://chromium-review.googlesource.com/944750
Commit-Queue: Yash Malik <ymalik@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#540391}(cherry picked from commit d68a05a)
Reviewed-on: https://chromium-review.googlesource.com/952644
Reviewed-by: Yash Malik <ymalik@chromium.org>
Cr-Commit-Position: refs/branch-heads/3359@{#52}
Cr-Branched-From: 66afc5e-refs/heads/master@{#540276}
rogerwang pushed a commit that referenced this pull request Apr 25, 2018
[Merge to M67]ash: Start pre-shutdown animation if long press power b…
e801fae 
…utton when menu is already shown.

TBR=minch@chromium.org

- Don't dismiss the menu if pressing power button when menu is already shown.
  Wait for 650ms to start the pre-shutdown animation and request focus for
  'power off' item instead.

- Turn screen off for convertible device / in tablet mode if
  "ModeSpecificPowerButton" is set when menu is not fully shown or second
   press before starting the pre-shutdown animation.

Test=PowerButtonControllerTest*

(cherry picked from commit b432b7c)

Bug: 826057
Change-Id: I1f906e2bcf5d91960180742bf558c00784fbaa1e
Reviewed-on: https://chromium-review.googlesource.com/1011590
Commit-Queue: Min Chen <minch@chromium.org>
Reviewed-by: Qiang Xu <warx@google.com>
Reviewed-by: Dan Erat <derat@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#550785}
Reviewed-on: https://chromium-review.googlesource.com/1015524
Reviewed-by: Min Chen <minch@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#52}
Cr-Branched-From: 9ef2aa8-refs/heads/master@{#550428}
rogerwang pushed a commit that referenced this pull request Jun 19, 2018
@jacobdufault-google
cros: Fix login crash when determining if PIN is supported.
11b08f2 
TBR=jdufault@google.com

(cherry picked from commit 4c830fc)

Bug: 847040
Change-Id: Id32b31abdfa1dff8e8229bfb4eaa610d782d4789
Reviewed-on: https://chromium-review.googlesource.com/1077017
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#562611}
Reviewed-on: https://chromium-review.googlesource.com/1080038
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#52}
Cr-Branched-From: 010ddcf-refs/heads/master@{#561733}
GnorTech pushed a commit that referenced this pull request Aug 4, 2018
Incrementing VERSION to 69.0.3497.11
9566134 
TBR=mmoss@chromium.org

Change-Id: I76d732efaec2cf870c8ca9b1d9105180f9225622
Reviewed-on: https://chromium-review.googlesource.com/1148961
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#52}
Cr-Branched-From: 271eaf5-refs/heads/master@{#576753}
rogerwang pushed a commit that referenced this pull request Sep 15, 2018
NativeDesktopMediaList: do desktop capture on an exclusive thread
9c00fb1 
webrtc::ScreenCapturerMac requires to be started and destroyed on same
thread. The current SequencedTaskRunner can't satisfy this and will
cause random crashes.
This cl is to use an exclusive capture thread as same as the one in
content/browser/media/capture/desktop_capture_device.cc.

Bug: 877982,851883
Change-Id: I6508add3660f63e1d2539dd2175a131f869a836a
Reviewed-on: https://chromium-review.googlesource.com/1199806
Commit-Queue: Weiyong Yao <braveyao@chromium.org>
Reviewed-by: Julien Isorce <julien.isorce@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#588151}(cherry picked from commit 3b9ecca)
Reviewed-on: https://chromium-review.googlesource.com/1207092
Reviewed-by: Weiyong Yao <braveyao@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#52}
Cr-Branched-From: 79f7c91-refs/heads/master@{#587811}
rogerwang pushed a commit that referenced this pull request Oct 31, 2018
Print Preview Refresh: Fix enter key blocked in pages input (M71)
82c07f1 
Bug: 894350
Change-Id: Ic5cde2aef449e745e1301ee0c09b6e9ad50308e3
Reviewed-on: https://chromium-review.googlesource.com/c/1278534
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#599291}(cherry picked from commit aa73099)
Reviewed-on: https://chromium-review.googlesource.com/c/1284056
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#52}
Cr-Branched-From: 4226ddf-refs/heads/master@{#599034}
rogerwang pushed a commit that referenced this pull request Dec 18, 2018
@caseq
DevTools: do not expose raw headers for cross-origin requests
3d6da28 
Same as https://chromium-review.googlesource.com/c/chromium/src/+/821410/,
but now for the network service.

Bug: 898306, 793692, 721408
Change-Id: I96a2a25e66f4ff528d84baf03d600e4f1c89dd30
Reviewed-on: https://chromium-review.googlesource.com/c/1313739
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#612685}(cherry picked from commit 1608dec)
Reviewed-on: https://chromium-review.googlesource.com/c/1361790
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#52}
Cr-Branched-From: d897fb1-refs/heads/master@{#612437}
rogerwang pushed a commit that referenced this pull request Feb 10, 2019
@wangxianzhu
[BlinkGenPropertyTrees] Fix crash when handling fullscreen pepper layer
00b672a 
RenderWidgetFullscreenPepper manages a cc layer without letting blink
know it, so the layer's paint property states are not set, causing
crashes.

This CL is temporary, by forcing cc::PropertyTreeBuilder to initialize
the paint properties of the pepper fullscreen root layer that is not
managed by blink.

TODO(crbug.com/925855): We should let blink manage the paint
properties for all content cc::Layers.

Test: https://chromium-review.googlesource.com/c/chromium/src/+/1437182
passes all CQ bots.

TBR=wangxianzhu@chromium.org

(cherry picked from commit 41d634c)

Bug: 913464,925855
Change-Id: I3438562f4671dce5224f8180616e2fe2af2f6cae
Reviewed-on: https://chromium-review.googlesource.com/c/1436493
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#626745}
Reviewed-on: https://chromium-review.googlesource.com/c/1444392
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/branch-heads/3683@{#52}
Cr-Branched-From: e510299-refs/heads/master@{#625896}
rogerwang pushed a commit that referenced this pull request Mar 24, 2019
Don't use custom load original logic for LitePageRedirect
419f5d5 
Bug: 940510
Change-Id: I376004ebb9568c5f55f123a40011a592a52e546c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1515237
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Auto-Submit: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#639567}(cherry picked from commit 426fd40152bb2931b7e6a086bf18071c46a8a84c)
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518469
Reviewed-by: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/branch-heads/3729@{#52}
Cr-Branched-From: d4a8972-refs/heads/master@{#638880}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ghostoy @rogerwang