Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add padding+hl to code_action servers #1420

Closed

Conversation

KevinSilvester
Copy link

  • Added padding before the showing server name for better readability
  • Created a new highlight group for server names

Before
image

After
image


Before
image

After
image

* Added padding before the showing server name for better readability
* Created new highlight group for server names
@glepnir
Copy link
Member

glepnir commented Apr 16, 2024

seems like top border is hidden ?

@KevinSilvester
Copy link
Author

KevinSilvester commented Apr 16, 2024

I think that may be due to a separate issue with the preview window.

I haven't really looked into the cause of the issue.
But from my experience the preview window sometimes appears underneath Code Actions window when:

  • There are a lot actions available for that line
  • The cursor is nearer the top of the buffer.

Plus all the screenshots under 'Before' were using the current main branch of lspsaga without any changes to its code.
This is a screen recording of the window overlap when using the main branch.

2024-04-16.17-59-32.mp4

@glepnir
Copy link
Member

glepnir commented May 19, 2024

After new refactor so do we still this now ?

@KevinSilvester
Copy link
Author

Yup all good to go.
The refactor seems to have fixed the overlapping issue

image

@glepnir
Copy link
Member

glepnir commented May 19, 2024

oh next step is refactor the ui of code action :) diagnostic jump more fancy now :p

@glepnir glepnir closed this May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants