Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file-descriptor mode column #253

Merged
merged 2 commits into from
Mar 24, 2023
Merged

Add file-descriptor mode column #253

merged 2 commits into from
Mar 24, 2023

Conversation

CKolkey
Copy link
Contributor

@CKolkey CKolkey commented Mar 23, 2023

Screenshot 2023-03-23 at 22 14 47

Screenshot 2023-03-23 at 22 18 34

Screenshot 2023-03-23 at 22 18 21

I noticed that the order of the columns was being shuffled every time you restart neovim, so I changed the iterator slightly so the order is consistent every time.

I also added entry.lstat to be able to accurately display if a fd is a symlink or not, since stat follows links.

Finally, @ is appended to flagged fd's.

@jamestrew
Copy link
Collaborator

Nice!

I noticed that the order of the columns was being shuffled every time you restart neovim, so I changed the iterator slightly so the order is consistent every time.

This was also kinda bothering me but hadn't gotten around to it so nice again.

I'm not familiar with the @ symbol. I think that's a macOS thing right?

@jamestrew
Copy link
Collaborator

jamestrew commented Mar 23, 2023

Also this is another reason it would be nice to have different highlighting for a single entry item.
image
Edit: I now have something cooking for this.

I also wonder, if it's worth adding the owner/group info as well. It doesn't have to be in this PR but something to consider.

@CKolkey
Copy link
Contributor Author

CKolkey commented Mar 24, 2023

It would be super cool to color the individual parts like your screenshot - I considered implementing that next but if you're on it already then thats awesome 🤩

You might be right, the @ is probably a mac thing. Its only on system dirs, so.. donno how linux/win does flags in stat output.

Lemme know if theres more you want to add here, otherwise this PR is done in my eyes

Copy link
Member

@fdschmidt93 fdschmidt93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contributions!

Quick test looks like it works as intended and, while I agree we should maybe add owner and character highlighting, let's do that in a follow up PR.

@fdschmidt93 fdschmidt93 merged commit ff558dd into nvim-telescope:master Mar 24, 2023
@CKolkey CKolkey deleted the add-file-mode branch March 24, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants