Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wait for writing rocks.toml to complete where possible #323

Merged
merged 1 commit into from
May 18, 2024
Merged

fix: wait for writing rocks.toml to complete where possible #323

merged 1 commit into from
May 18, 2024

Conversation

mrcjkb
Copy link
Member

@mrcjkb mrcjkb commented May 8, 2024

No description provided.

@mrcjkb mrcjkb requested a review from vhyrro May 8, 2024 20:11
@mrcjkb mrcjkb requested a review from NTBBloodbath as a code owner May 8, 2024 20:11
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 8, 2024 •
edited by mrcjkb

Review Checklist

Does this PR follow the Contribution Guidelines? Following is a partial checklist:

Proper conventional commit scoping:

  • For example, fix(installer): some installer bugfix

  • Pull request title has the appropriate conventional commit prefix.

If applicable:

  • Tested
    • Tests have been added.
    • Tested manually (steps in PR description).
  • Updated documentation.

@mrcjkb mrcjkb mentioned this pull request May 8, 2024
Merged
@mrcjkb
Copy link
Member Author

mrcjkb commented May 8, 2024

CI failure is fixed in #324

@mrcjkb mrcjkb changed the title fix: wait for writing rocks.toml to complet where possible fix: wait for writing rocks.toml to complet3 where possible May 8, 2024
@mrcjkb mrcjkb changed the title fix: wait for writing rocks.toml to complet3 where possible fix: wait for writing rocks.toml to complete where possible May 8, 2024
@mrcjkb mrcjkb mentioned this pull request May 8, 2024
Closed
@mrcjkb mrcjkb linked an issue May 8, 2024 that may be closed by this pull request
Bulk install fails to write to rocks.toml nvim-neorocks/rocks-git.nvim#28
Closed
@vhyrro vhyrro merged commit 37924fa into master May 18, 2024
6 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vhyrro vhyrro Awaiting requested review from vhyrro vhyrro is a code owner

@NTBBloodbath NTBBloodbath Awaiting requested review from NTBBloodbath NTBBloodbath is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bulk install fails to write to rocks.toml
2 participants
@mrcjkb @vhyrro