fix(fs_scan): ensure parents of all expanded nodes are also scanned #1393
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On refresh a list of expanded nodes is gathered to decide what paths to scan. However, when an expanded node lives inside a closed parent node, parent node's number of children will be wrong.
This results in unexpected behavior with
group_with_dirs
, so this fix ensures that all parent nodes are scanned.For more detailed explanation with screenshots please read: #833.
Fixes: #833