implemented changes intially created by @daog1 and addresses the comm… #1016
Conversation
…ents made by @cseickel on the pr nvim-neo-tree#938
| @@ -367,6 +367,8 @@ local config = { | |||
| ["p"] = "paste_from_clipboard", | |||
| ["c"] = "copy", -- takes text input for destination, also accepts the config.show_path and config.insert_as options | |||
| ["m"] = "move", -- takes text input for destination, also accepts the config.show_path and config.insert_as options | |||
| ["Y"] = "copy_path", | |||
| ["gy"] = "copy_abspath", | |||
There was a problem hiding this comment.
The only problem here is that the commands are defined at the global level so that it applies to all sources, but it is not really a command that will work universally. It should be mapped within the filesystem and buffers commands instead.
It also makes sense to use it in the git_status source.
There was a problem hiding this comment.
This is correct. For example, Netman explodes when you navigate to it's Neo-tree source because I don't have these commands implemented yet. IMO they should not be "common".
Or if they are, this release needs to be slow walked as this should be considered a "Breaking Change" for 3rd party developers using Neo-tree.
That said, I really like this feature, so whatever command is decided on, I will implement it in Netman. But the fact that this causes an error on source load means this is IMO a breaking change.
There was a problem hiding this comment.
Forgive my ignorance, and would you explain it in more detail,thx alot
| @@ -52,6 +52,14 @@ M.copy = function(state) | |||
| cc.copy(state, redraw) | |||
| end | |||
|
|
|||
| M.copy_path = function(state) | |||
There was a problem hiding this comment.
I don't think this is needed at all because there is a
cc._add_common_commands(M)
call at the end of the file, which will add this command anyhow. This pattern of wrapping common commands is only needed when we need to alter the common command in some way, such as by adding a redraw callback.
| local pwdpath = state.path | ||
| local content = node.path |
There was a problem hiding this comment.
Since this is a common command, there's no guarantee that either of these exist for all sources.
| local pwdpath = state.path | |
| local content = node.path | |
| local pwdpath = state.path or "" | |
| local content = node.path or node:get_id() |
| M.copy_path = function(state) | ||
| cc.copy_path(state) | ||
| end | ||
|
|
||
| M.copy_abspath = function(state) | ||
| cc.copy_abspath(state) | ||
| end | ||
|
|
There was a problem hiding this comment.
These can be deleted as well.
This PR continues where #938 left off - I really want this feature - but it seems that @daog1 has abandoned the change.
This PR is a carbon copy of his changes with the addition of the suggestions made in the comments.