Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): upgrade @nuxt/content@2.6 #127

Closed
wants to merge 1 commit into from

Conversation

farnabaz
Copy link
Contributor

@farnabaz farnabaz commented Apr 20, 2023

I've tried to upgrade other deps, but seems that it brokes dark mode. All text will be black 😬

@codesandbox
Copy link

codesandbox bot commented Apr 20, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@vercel
Copy link

vercel bot commented Apr 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
alpine ✅ Ready (Inspect) Visit Preview Apr 20, 2023 10:23am

@farnabaz farnabaz requested a review from Tahul April 20, 2023 10:23
@Tahul
Copy link
Contributor

Tahul commented May 10, 2023

Hey @farnabaz ; I've done this in another commit, thanks for this one!

I also fixed the issue with upgrading other dependencies.

As for context, @nuxt-themes/typography used to ship some defaults as .css for text purposes.

Now the default is up to the user project instead, avoiding conflicting CSS conflicts.

That's what lead to the text being black in both dark & light mode.

@Tahul Tahul closed this May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants